2023-09-19 02:47:19

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement

The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
to what the core driver selects in order to provide this API.
This fixes a build error:

aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'

Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Charles Keepax <[email protected]>
Cc: James Schulman <[email protected]>
Cc: David Rhodes <[email protected]>
Cc: Richard Fitzgerald <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Lee Jones <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -241,6 +241,7 @@ config MFD_CS42L43
tristate
select MFD_CORE
select REGMAP
+ select REGMAP_IRQ

config MFD_CS42L43_I2C
tristate "Cirrus Logic CS42L43 (I2C)"


2023-09-19 17:22:13

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement

On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
> The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
> to what the core driver selects in order to provide this API.
> This fixes a build error:
>
> aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
> cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
>
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Charles Keepax <[email protected]>
> Cc: James Schulman <[email protected]>
> Cc: David Rhodes <[email protected]>
> Cc: Richard Fitzgerald <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Lee Jones <[email protected]>
> ---

Someone already sent a fix for this, that is awaiting review:

https://lore.kernel.org/lkml/[email protected]/

But just incase this one gets picked up:

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles