2023-09-19 14:05:05

by Lee Jones

Subject: Re: [PATCH v3 10/12] regulator: mt6358: Add missing regulators for MT6366

On Tue, 19 Sep 2023, Chen-Yu Tsai wrote:

> When support for the MT6366 PMIC regulators was added, it was assumed
> that it had the same functionality as MT6358. In reality there are
> differences. A few regulators have different ranges, or were renamed
> and repurposed, or removed altogether.
>
> Add the 3 regulators that were missing from the original submission.
> These are added for completeness. VSRAM_CORE is not used in existing
> projects. VM18 and VMDDR feed DRAM related consumers, and are not used
> in-kernel.
>
> Signed-off-by: Chen-Yu Tsai <[email protected]>
> ---
> Changes since v2:
> - Linear range selector values fixed
>
> Angelo's reviewed-by was dropped.
>
> drivers/regulator/mt6358-regulator.c | 20 ++++++++++++++++++++

> include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++

Acked-by: Lee Jones <[email protected]>

> include/linux/regulator/mt6358-regulator.h | 3 +++
> 3 files changed, 40 insertions(+)

[...]

--
Lee Jones [李琼斯]

2023-09-22 00:17:23

by Chen-Yu Tsai

Subject: Re: [PATCH v3 10/12] regulator: mt6358: Add missing regulators for MT6366

On Tue, Sep 19, 2023 at 9:55 PM Lee Jones <[email protected]> wrote:
>
> On Tue, 19 Sep 2023, Chen-Yu Tsai wrote:
>
> > When support for the MT6366 PMIC regulators was added, it was assumed
> > that it had the same functionality as MT6358. In reality there are
> > differences. A few regulators have different ranges, or were renamed
> > and repurposed, or removed altogether.
> >
> > Add the 3 regulators that were missing from the original submission.
> > These are added for completeness. VSRAM_CORE is not used in existing
> > projects. VM18 and VMDDR feed DRAM related consumers, and are not used
> > in-kernel.
> >
> > Signed-off-by: Chen-Yu Tsai <[email protected]>
> > ---
> > Changes since v2:
> > - Linear range selector values fixed
> >
> > Angelo's reviewed-by was dropped.
> >
> > drivers/regulator/mt6358-regulator.c | 20 ++++++++++++++++++++
>
> > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++
>
> Acked-by: Lee Jones <[email protected]>

Thanks! Could you also take a look at another patch this series is
based on and ack that one?

It's "regulator: mt6358: Add output voltage fine tuning to fixed regulators",
with message ID "[email protected]" [1].


ChenYu

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/

>
> > include/linux/regulator/mt6358-regulator.h | 3 +++
> > 3 files changed, 40 insertions(+)
>
> [...]
>
> --
> Lee Jones [李琼斯]