2023-09-19 14:10:12

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v3 01/12] dt-bindings: mfd: mt6397: Split out compatible for MediaTek MT6366 PMIC

Mark,

Please notify me when you apply the other patches in this set and I'll
come back and merge this one.

On Tue, 19 Sep 2023, Chen-Yu Tsai wrote:

> The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has
> a different set of regulators. Specifically, it lacks the camera related
> VCAM* LDOs and VLDO28, but has additional VM18, VMDDR, and VSRAM_CORE LDOs.
>
> The PMICs contain a chip ID register that can be used to detect which
> exact model is preset, so it is possible to share a common base
> compatible string.
>
> Add a separate compatible for the MT6366 PMIC, with a fallback to the
> MT6358 PMIC.
>
> Fixes: 49be16305587 ("dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC")
> Signed-off-by: Chen-Yu Tsai <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/mt6397.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 294693a8906c..10540aa7afa1 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -22,8 +22,9 @@ compatible:
> "mediatek,mt6323" for PMIC MT6323
> "mediatek,mt6331" for PMIC MT6331 and MT6332
> "mediatek,mt6357" for PMIC MT6357
> - "mediatek,mt6358" for PMIC MT6358 and MT6366
> + "mediatek,mt6358" for PMIC MT6358
> "mediatek,mt6359" for PMIC MT6359
> + "mediatek,mt6366", "mediatek,mt6358" for PMIC MT6366
> "mediatek,mt6397" for PMIC MT6397
>
> Optional subnodes:
> @@ -40,6 +41,7 @@ Optional subnodes:
> - compatible: "mediatek,mt6323-regulator"
> see ../regulator/mt6323-regulator.txt
> - compatible: "mediatek,mt6358-regulator"
> + - compatible: "mediatek,mt6366-regulator", "mediatek-mt6358-regulator"
> see ../regulator/mt6358-regulator.txt
> - compatible: "mediatek,mt6397-regulator"
> see ../regulator/mt6397-regulator.txt
> --
> 2.42.0.459.ge4e396fd5e-goog
>

--
Lee Jones [李琼斯]