2023-09-20 10:07:55

by Max Filippov

Subject: [PATCH v2 4/5] dt-bindings: serial: document esp32s3-acm

Add documentation for the ESP32S3 USB CDC-ACM controller.

Signed-off-by: Max Filippov <[email protected]>

---
Changes v1->v2:
- fix description
- rename node in the example
- fix example indentation

.../bindings/serial/esp,esp32-acm.yaml | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/esp,esp32-acm.yaml

diff --git a/Documentation/devicetree/bindings/serial/esp,esp32-acm.yaml b/Documentation/devicetree/bindings/serial/esp,esp32-acm.yaml
new file mode 100644
index 000000000000..6ec836db694a
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/esp,esp32-acm.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/esp,esp32-acm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ESP32S3 ACM controller
+
+maintainers:
+ - Max Filippov <[email protected]>
+
+description:
+ Fixed function USB CDC-ACM device controller of the Espressif ESP32S3 SoC.
+
+properties:
+ compatible:
+ const: esp,esp32s3-acm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ serial@60038000 {
+ compatible = "esp,esp32s3-acm";
+ reg = <0x60038000 0x1000>;
+ interrupts = <96 3 0>;
+ };
--
2.30.2

2023-09-20 14:34:16

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 4/5] dt-bindings: serial: document esp32s3-acm

On 20/09/2023 04:26, Max Filippov wrote:
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +

Same comment here - missing $ref to serial.yaml. Sorry for no bringing
it up earlier.

Best regards,
Krzysztof