2023-09-20 07:58:45

by Neha Malcom Francis

Subject: [PATCH 1/1] arm64: dts: ti: k3-j721e-mcu-wakeup: Add MCU domain ESM instance

Currently J721E defines only the main_esm in DTS. Add node for mcu_esm
as well.

Signed-off-by: Neha Malcom Francis <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index 05d6ef127ba7..fa8af20c7818 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -671,4 +671,11 @@ wkup_vtm0: temperature-sensor@42040000 {
power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
#thermal-sensor-cells = <1>;
};
+
+ mcu_esm: esm@40800000 {
+ compatible = "ti,j721e-esm";
+ reg = <0x00 0x40800000 0x00 0x1000>;
+ ti,esm-pins = <95>;
+ bootph-pre-ram;
+ };
};
--
2.34.1

2023-09-22 00:05:40

by Neha Malcom Francis

Subject: Re: [PATCH 1/1] arm64: dts: ti: k3-j721e-mcu-wakeup: Add MCU domain ESM instance

Hi Udit

On 21-Sep-23 4:29 PM, Kumar, Udit wrote:
>
> On 9/20/2023 12:00 PM, Neha Malcom Francis wrote:
>> Currently J721E defines only the main_esm in DTS. Add node for mcu_esm
>> as well.
> Could you please add some more description in commit message , why we
> need mcu_esm node.

Yes I will add that in, thanks for reviewing!

>> Signed-off-by: Neha Malcom Francis <[email protected]>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> index 05d6ef127ba7..fa8af20c7818 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
>> @@ -671,4 +671,11 @@ wkup_vtm0: temperature-sensor@42040000 {
>>           power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
>>           #thermal-sensor-cells = <1>;
>>       };
>> +
>> +    mcu_esm: esm@40800000 {
>> +        compatible = "ti,j721e-esm";
>> +        reg = <0x00 0x40800000 0x00 0x1000>;
>> +        ti,esm-pins = <95>;
>> +        bootph-pre-ram;
>> +    };
>>   };
>
> With that change
>
> Reviewed-by: Udit Kumar <[email protected]>
>
>

Thanking You
Neha Malcom Francis

2023-09-22 00:14:03

by Kumar, Udit

Subject: Re: [PATCH 1/1] arm64: dts: ti: k3-j721e-mcu-wakeup: Add MCU domain ESM instance

On 9/20/2023 12:00 PM, Neha Malcom Francis wrote:
> Currently J721E defines only the main_esm in DTS. Add node for mcu_esm
> as well.
Could you please add some more description in commit message , why we
need mcu_esm node.
> Signed-off-by: Neha Malcom Francis <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 05d6ef127ba7..fa8af20c7818 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -671,4 +671,11 @@ wkup_vtm0: temperature-sensor@42040000 {
> power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
> #thermal-sensor-cells = <1>;
> };
> +
> + mcu_esm: esm@40800000 {
> + compatible = "ti,j721e-esm";
> + reg = <0x00 0x40800000 0x00 0x1000>;
> + ti,esm-pins = <95>;
> + bootph-pre-ram;
> + };
> };

With that change

Reviewed-by: Udit Kumar <[email protected]>