2023-09-20 23:06:53

by charles.kearney

[permalink] [raw]
Subject: [PATCH v1 0/1] spi: spi-gxp: BUG: Correct spi write return value

From: Charles Kearney <[email protected]>

Bug fix to correct return value of gxp_spi_write function to zero.
Completion of succesful operation should return zero.

Fixes: 730bc8ba5e9e spi: spi-gxp: Add support for HPE GXP SoCs

Charles Kearney (1):
spi: spi-gxp: BUG: Correct spi write return value

drivers/spi/spi-gxp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.25.1


2023-09-20 23:54:30

by charles.kearney

[permalink] [raw]
Subject: [PATCH v1 1/1] spi: spi-gxp: BUG: Correct spi write return value

From: Charles Kearney <[email protected]>

Bug fix to correct return value of gxp_spi_write function to zero.
Completion of succesful operation should return zero.

Fixes: 730bc8ba5e9e spi: spi-gxp: Add support for HPE GXP SoCs

Signed-off-by: Charles Kearney <[email protected]>
---
drivers/spi/spi-gxp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-gxp.c b/drivers/spi/spi-gxp.c
index fd2fac236bbd..3aff5a166c94 100644
--- a/drivers/spi/spi-gxp.c
+++ b/drivers/spi/spi-gxp.c
@@ -194,7 +194,7 @@ static ssize_t gxp_spi_write(struct gxp_spi_chip *chip, const struct spi_mem_op
return ret;
}

- return write_len;
+ return 0;
}

static int do_gxp_exec_mem_op(struct spi_mem *mem, const struct spi_mem_op *op)
--
2.25.1

2023-09-27 15:20:07

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 0/1] spi: spi-gxp: BUG: Correct spi write return value

On Wed, Sep 20, 2023 at 09:53:38PM +0000, [email protected] wrote:
> From: Charles Kearney <[email protected]>
>
> Bug fix to correct return value of gxp_spi_write function to zero.
> Completion of succesful operation should return zero.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.


Attachments:
(No filename) (562.00 B)
signature.asc (499.00 B)
Download all attachments

2023-09-28 08:51:02

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 0/1] spi: spi-gxp: BUG: Correct spi write return value

On Wed, 20 Sep 2023 21:53:38 +0000, [email protected] wrote:
> Bug fix to correct return value of gxp_spi_write function to zero.
> Completion of succesful operation should return zero.
>
> Fixes: 730bc8ba5e9e spi: spi-gxp: Add support for HPE GXP SoCs
>
> Charles Kearney (1):
> spi: spi-gxp: BUG: Correct spi write return value
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-gxp: BUG: Correct spi write return value
commit: 1a8196a93e493c0a50b800cb09cef60b124eee15

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark