Enable GPU/WCNSS properly in some MSM8916/MSM8939 boards that were
changed after I sent the patches for the dynamic reserved memory
allocation.
I have magic scripts that make the necessary changes automatically so
I'm quite sure that I caught all new instances that need adjustment. :-)
Since my scripts only work properly on board DTs with sorted nodes
I also included a bonus patch to fix that in some of the MSM8916 DTs.
Signed-off-by: Stephan Gerhold <[email protected]>
---
Stephan Gerhold (3):
arm64: dts: qcom: msm8916-samsung-gt5: Enable GPU
arm64: dts: qcom: msm8939-longcheer-l9100: Enable wcnss_mem
arm64: dts: qcom: msm8916-*: Fix alphabetic node order
.../boot/dts/qcom/msm8916-alcatel-idol347.dts | 8 ++---
.../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 10 +++---
.../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 38 +++++++++++-----------
arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 4 +++
arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts | 4 +++
arch/arm64/boot/dts/qcom/msm8916-thwc-uf896.dts | 8 ++---
arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 8 ++---
.../arm64/boot/dts/qcom/msm8916-yiming-uz801v3.dts | 8 ++---
.../boot/dts/qcom/msm8939-longcheer-l9100.dts | 4 +++
9 files changed, 52 insertions(+), 40 deletions(-)
---
base-commit: a35461d47fe3e555602912b905f1bae7045256eb
change-id: 20230921-msm8916-rmem-fixups-46ec18b9ba5d
Best regards,
--
Stephan Gerhold <[email protected]>
Enable &wcnss_mem for msm8939-longcheer-l9100. This is needed now to
have WCNSS working. It was missed when &wcnss_mem was disabled by
default because the patch with the msm8939-longcheer-l9100 device tree
was not applied yet.
Fixes: 0ece6438a8c0 ("arm64: dts: qcom: msm8916/39: Disable unneeded firmware reservations")
Signed-off-by: Stephan Gerhold <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
index 6802714fda3f..a3357513037c 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
@@ -247,6 +247,10 @@ &wcnss_iris {
compatible = "qcom,wcn3620";
};
+&wcnss_mem {
+ status = "okay";
+};
+
&tlmm {
button_backlight_default: button-backlight-default-state {
pins = "gpio17";
--
2.42.0
On 21/09/2023 19:56, Stephan Gerhold wrote:
> Enable GPU/WCNSS properly in some MSM8916/MSM8939 boards that were
> changed after I sent the patches for the dynamic reserved memory
> allocation.
>
> I have magic scripts that make the necessary changes automatically so
> I'm quite sure that I caught all new instances that need adjustment. :-)
>
> Since my scripts only work properly on board DTs with sorted nodes
> I also included a bonus patch to fix that in some of the MSM8916 DTs.
>
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> Stephan Gerhold (3):
> arm64: dts: qcom: msm8916-samsung-gt5: Enable GPU
> arm64: dts: qcom: msm8939-longcheer-l9100: Enable wcnss_mem
> arm64: dts: qcom: msm8916-*: Fix alphabetic node order
>
> .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 8 ++---
> .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 10 +++---
> .../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 38 +++++++++++-----------
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 4 +++
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts | 4 +++
> arch/arm64/boot/dts/qcom/msm8916-thwc-uf896.dts | 8 ++---
> arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 8 ++---
> .../arm64/boot/dts/qcom/msm8916-yiming-uz801v3.dts | 8 ++---
> .../boot/dts/qcom/msm8939-longcheer-l9100.dts | 4 +++
> 9 files changed, 52 insertions(+), 40 deletions(-)
> ---
> base-commit: a35461d47fe3e555602912b905f1bae7045256eb
> change-id: 20230921-msm8916-rmem-fixups-46ec18b9ba5d
>
> Best regards,
Do these Fixes shas exist ? I can't seem to find them.
---
bod
On Sat, Sep 23, 2023 at 04:12:25PM +0100, Bryan O'Donoghue wrote:
> On 21/09/2023 19:56, Stephan Gerhold wrote:
> > Enable GPU/WCNSS properly in some MSM8916/MSM8939 boards that were
> > changed after I sent the patches for the dynamic reserved memory
> > allocation.
> >
> > I have magic scripts that make the necessary changes automatically so
> > I'm quite sure that I caught all new instances that need adjustment. :-)
> >
> > Since my scripts only work properly on board DTs with sorted nodes
> > I also included a bonus patch to fix that in some of the MSM8916 DTs.
> >
> > Signed-off-by: Stephan Gerhold <[email protected]>
> > ---
> > Stephan Gerhold (3):
> > arm64: dts: qcom: msm8916-samsung-gt5: Enable GPU
> > arm64: dts: qcom: msm8939-longcheer-l9100: Enable wcnss_mem
> > arm64: dts: qcom: msm8916-*: Fix alphabetic node order
> >
> > .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 8 ++---
> > .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 10 +++---
> > .../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 38 +++++++++++-----------
> > arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 4 +++
> > arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts | 4 +++
> > arch/arm64/boot/dts/qcom/msm8916-thwc-uf896.dts | 8 ++---
> > arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 8 ++---
> > .../arm64/boot/dts/qcom/msm8916-yiming-uz801v3.dts | 8 ++---
> > .../boot/dts/qcom/msm8939-longcheer-l9100.dts | 4 +++
> > 9 files changed, 52 insertions(+), 40 deletions(-)
> > ---
> > base-commit: a35461d47fe3e555602912b905f1bae7045256eb
> > change-id: 20230921-msm8916-rmem-fixups-46ec18b9ba5d
> >
>
> Do these Fixes shas exist ? I can't seem to find them.
>
Yes, fetch for-next from
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
It did not end up in linux-next yet because the ARM32 build in the
qcom tree is broken currently [1].
[1]: https://lore.kernel.org/linux-next/[email protected]/
Am Donnerstag, dem 21.09.2023 um 20:56 +0200 schrieb Stephan Gerhold:
> Enable &wcnss_mem for msm8939-longcheer-l9100. This is needed now to
> have WCNSS working. It was missed when &wcnss_mem was disabled by
> default because the patch with the msm8939-longcheer-l9100 device
> tree
> was not applied yet.
>
> Fixes: 0ece6438a8c0 ("arm64: dts: qcom: msm8916/39: Disable unneeded
> firmware reservations")
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
> b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
> index 6802714fda3f..a3357513037c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
> @@ -247,6 +247,10 @@ &wcnss_iris {
> compatible = "qcom,wcn3620";
> };
>
> +&wcnss_mem {
> + status = "okay";
> +};
> +
> &tlmm {
> button_backlight_default: button-backlight-default-state {
> pins = "gpio17";
>
Reviewed-by: André Apitzsch <[email protected]>
Tested-by: André Apitzsch <[email protected]>
On Thu, 21 Sep 2023 20:56:03 +0200, Stephan Gerhold wrote:
> Enable GPU/WCNSS properly in some MSM8916/MSM8939 boards that were
> changed after I sent the patches for the dynamic reserved memory
> allocation.
>
> I have magic scripts that make the necessary changes automatically so
> I'm quite sure that I caught all new instances that need adjustment. :-)
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: msm8916-samsung-gt5: Enable GPU
commit: e87cef6a035edc03b4ac98f88121c706b2843156
[2/3] arm64: dts: qcom: msm8939-longcheer-l9100: Enable wcnss_mem
commit: d63ae4a814a763a5d2d4d078073562698693a909
[3/3] arm64: dts: qcom: msm8916-*: Fix alphabetic node order
commit: b364cc485da1b769f1ead705dcd853e87b42f96e
Best regards,
--
Bjorn Andersson <[email protected]>