2023-09-20 13:04:57

by Nishanth Menon

Subject: Re: [PATCH] firmware: ti_sci: Mark driver as non removable

On 22:47-20230907, Dhruva Gole wrote:
> The TI-SCI message protocol provides a way to communicate between
> various compute processors with a central system controller entity. It
> provides the fundamental device management capability and clock control
> in the SOCs that it's used in.
>
> Ensure that the driver isn't unbound by suppressing its bind and unbind
> sysfs attributes. As the driver is built-in there is no way to remove
> device once bound.
>
> We can also remove the ti_sci_remove call along with the
> ti_sci_debugfs_destroy as there are no callers for it any longer.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Suggested-by: Uwe Kleine-K?nig <[email protected]>
> Signed-off-by: Dhruva Gole <[email protected]>

Add Reported-by and Closes tags

Also please address the comment from Uwe on improving the commit message

[...]

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-09-22 05:45:25

by Dhruva Gole

Subject: Re: [PATCH] firmware: ti_sci: Mark driver as non removable

On Sep 20, 2023 at 07:59:04 -0500, Nishanth Menon wrote:
> On 22:47-20230907, Dhruva Gole wrote:
> > The TI-SCI message protocol provides a way to communicate between
> > various compute processors with a central system controller entity. It
> > provides the fundamental device management capability and clock control
> > in the SOCs that it's used in.
> >
> > Ensure that the driver isn't unbound by suppressing its bind and unbind
> > sysfs attributes. As the driver is built-in there is no way to remove
> > device once bound.
> >
> > We can also remove the ti_sci_remove call along with the
> > ti_sci_debugfs_destroy as there are no callers for it any longer.
> >
> > Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> > Suggested-by: Uwe Kleine-K?nig <[email protected]>
> > Signed-off-by: Dhruva Gole <[email protected]>
>
> Add Reported-by and Closes tags
>
> Also please address the comment from Uwe on improving the commit message

Sent V2 patch here:
https://lore.kernel.org/all/[email protected]/T/#u

>
> [...]
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

--
Best regards,
Dhruva Gole <[email protected]>