2023-09-21 20:12:57

by Sudeep Holla

[permalink] [raw]
Subject: Re: [PATCH] firmware: arm_scmi: Move power-domain driver to the pmdomain dir

On Thu, Sep 21, 2023 at 03:10:56PM +0200, Ulf Hansson wrote:
> On Thu, 21 Sept 2023 at 13:33, Sudeep Holla <[email protected]> wrote:
> >
> > To simplify with maintenance let's move the Arm SCMI power-domain driver
> > to the new pmdomain directory.
> >
> > Cc: Ulf Hansson <[email protected]>
> > Cc: Cristian Marussi <[email protected]>
> > Signed-off-by: Sudeep Holla <[email protected]>
>
> Reviewed-by: Ulf Hansson <[email protected]>
>
> Feel free to take it through your scmi tree!
>
> Note that, we should move the Kconfig options too, but that requires
> changes that I am carrying in my pmdomain tree. We can either wait
> until the next cycle or you could send your pull-request to me this
> time (instead of through arm-soc), then we can fix this as a late
> minute change. The decision is yours.
>

OK. Lets us just delay SCMI Kconfig changes for the next cycle then. I assume
you would have other changes merged by then. Or may be as a fix as it would
be hardlt 10-15 line with 2 Kconfig options. Let me know if you disagree or
have other ideas.

--
Regards,
Sudeep


2023-09-21 23:13:54

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] firmware: arm_scmi: Move power-domain driver to the pmdomain dir

On Thu, 21 Sept 2023 at 15:33, Sudeep Holla <[email protected]> wrote:
>
> On Thu, Sep 21, 2023 at 03:10:56PM +0200, Ulf Hansson wrote:
> > On Thu, 21 Sept 2023 at 13:33, Sudeep Holla <[email protected]> wrote:
> > >
> > > To simplify with maintenance let's move the Arm SCMI power-domain driver
> > > to the new pmdomain directory.
> > >
> > > Cc: Ulf Hansson <[email protected]>
> > > Cc: Cristian Marussi <[email protected]>
> > > Signed-off-by: Sudeep Holla <[email protected]>
> >
> > Reviewed-by: Ulf Hansson <[email protected]>
> >
> > Feel free to take it through your scmi tree!
> >
> > Note that, we should move the Kconfig options too, but that requires
> > changes that I am carrying in my pmdomain tree. We can either wait
> > until the next cycle or you could send your pull-request to me this
> > time (instead of through arm-soc), then we can fix this as a late
> > minute change. The decision is yours.
> >
>
> OK. Lets us just delay SCMI Kconfig changes for the next cycle then. I assume
> you would have other changes merged by then. Or may be as a fix as it would
> be hardlt 10-15 line with 2 Kconfig options. Let me know if you disagree or
> have other ideas.

Let's delay, it's probably easier. Maybe a fix for rc1 would be best.

Kind regards
Uffe