2023-09-22 20:52:30

by Stephan Gerhold

Subject: [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators

Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
the following dtbs_check warnings. They are all also supplied by
pm8916_l6 so there is no functional difference.

apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
from schema display/bridge/adi,adv7533.yaml

Fixes: 28546b095511 ("arm64: dts: apq8016-sbc: Add HDMI display support")
Signed-off-by: Stephan Gerhold <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 3c51f891029e..9ffad7d1f2b6 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -172,6 +172,9 @@ adv_bridge: bridge@39 {
pd-gpios = <&tlmm 32 GPIO_ACTIVE_HIGH>;

avdd-supply = <&pm8916_l6>;
+ a2vdd-supply = <&pm8916_l6>;
+ dvdd-supply = <&pm8916_l6>;
+ pvdd-supply = <&pm8916_l6>;
v1p2-supply = <&pm8916_l6>;
v3p3-supply = <&pm8916_l17>;


---
base-commit: a35461d47fe3e555602912b905f1bae7045256eb
change-id: 20230922-db410c-adv7533-regulators-89a607130f1d

Best regards,
--
Stephan Gerhold <[email protected]>

2023-09-23 19:17:00

by Dmitry Baryshkov

Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators

On Fri, 22 Sept 2023 at 13:50, Stephan Gerhold <[email protected]> wrote:
>
> Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
> the following dtbs_check warnings. They are all also supplied by
> pm8916_l6 so there is no functional difference.
>
> apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
> from schema display/bridge/adi,adv7533.yaml
>
> Fixes: 28546b095511 ("arm64: dts: apq8016-sbc: Add HDMI display support")
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 3 +++
> 1 file changed, 3 insertions(+)

Reviewed-by: Dmitry Baryshkov <[email protected]>



--
With best wishes
Dmitry

2023-09-28 00:58:02

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators

On Fri, 22 Sep 2023 12:49:55 +0200, Stephan Gerhold wrote:
> Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
> the following dtbs_check warnings. They are all also supplied by
> pm8916_l6 so there is no functional difference.
>
> apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
> from schema display/bridge/adi,adv7533.yaml
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators
commit: 33e9032a1875bb1aee3c68a4540f5a577ff44130

Best regards,
--
Bjorn Andersson <[email protected]>