2023-09-25 01:07:35

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH V3 1/3] arm64: dts: imx8mp: Add easrc node

On Wed, Aug 30, 2023 at 11:44:29PM -0500, Adam Ford wrote:
> The i.MX8MP has an asynchronous sample rate converter which seems
> to be the same as what is available on the i.MX8M Nano.
>
> Signed-off-by: Adam Ford <[email protected]>
> ---
> V3: No Change. The dt-binding update was already accepted into the sound tree, so that patch
> was dropped from the series
>
> V2: No Change.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 83d907294fbc..3167706d81e1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1459,6 +1459,26 @@ sai7: sai@30c80000 {
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> +
> + easrc: easrc@30c90000 {
> + compatible = "fsl,imx8mp-easrc", "fsl,imx8mn-easrc";
> + reg = <0x30c90000 0x10000>;
> + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_ASRC_IPG>;
> + clock-names = "mem";
> + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>,
> + <&sdma2 18 23 0> , <&sdma2 19 23 0>,
> + <&sdma2 20 23 0> , <&sdma2 21 23 0>,
> + <&sdma2 22 23 0> , <&sdma2 23 23 0>;
> + dma-names = "ctx0_rx", "ctx0_tx",
> + "ctx1_rx", "ctx1_tx",
> + "ctx2_rx", "ctx2_tx",
> + "ctx3_rx", "ctx3_tx";
> + firmware-name = "imx/easrc/easrc-imx8mn.bin";
> + fsl,asrc-rate = <8000>;

One space before =

Shawn

> + fsl,asrc-format = <2>;
> + status = "disabled";
> + };
> };
>
> sdma3: dma-controller@30e00000 {
> --
> 2.39.2
>


2023-09-25 01:12:35

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH V3 1/3] arm64: dts: imx8mp: Add easrc node

On Mon, Sep 25, 2023 at 9:07 AM Shawn Guo <[email protected]> wrote:
>
> On Wed, Aug 30, 2023 at 11:44:29PM -0500, Adam Ford wrote:
> > The i.MX8MP has an asynchronous sample rate converter which seems
> > to be the same as what is available on the i.MX8M Nano.
> >
> > Signed-off-by: Adam Ford <[email protected]>
> > ---
> > V3: No Change. The dt-binding update was already accepted into the sound tree, so that patch
> > was dropped from the series
> >
> > V2: No Change.
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 83d907294fbc..3167706d81e1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1459,6 +1459,26 @@ sai7: sai@30c80000 {
> > interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> > status = "disabled";
> > };
> > +
> > + easrc: easrc@30c90000 {
> > + compatible = "fsl,imx8mp-easrc", "fsl,imx8mn-easrc";
> > + reg = <0x30c90000 0x10000>;
> > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_ASRC_IPG>;
> > + clock-names = "mem";
> > + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>,
> > + <&sdma2 18 23 0> , <&sdma2 19 23 0>,
> > + <&sdma2 20 23 0> , <&sdma2 21 23 0>,
> > + <&sdma2 22 23 0> , <&sdma2 23 23 0>;
> > + dma-names = "ctx0_rx", "ctx0_tx",
> > + "ctx1_rx", "ctx1_tx",
> > + "ctx2_rx", "ctx2_tx",
> > + "ctx3_rx", "ctx3_tx";
> > + firmware-name = "imx/easrc/easrc-imx8mn.bin";
> > + fsl,asrc-rate = <8000>;
>
> One space before =

I fixed it up and applied, thanks!