2023-09-25 16:11:02

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH 2/2] staging: rtl8192e: remove bogus __packed annotations

From: Arnd Bergmann <[email protected]>

The rtllib_rxb structure contains a pointer, so this is not a hardware
structure but could benefit from loading the pointer in a single
instruction rather than assembling it from four or eight individual
bytes.

Both structures are allocated as part of larger structure that
already enforce at least a 4-byte alignment, so there is no
reason to ever have to deal with misaligned definitions.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/staging/rtl8192e/rtllib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 7d26910a0b162..fe7b58ae33995 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -172,7 +172,7 @@ struct sw_chnl_cmd {
u32 Para1;
u32 Para2;
u32 msDelay;
-} __packed;
+};

/*--------------------------Define -------------------------------------------*/
#define MGN_1M 0x02
@@ -707,7 +707,7 @@ struct rtllib_rxb {
struct sk_buff *subframes[MAX_SUBFRAME_COUNT];
u8 dst[ETH_ALEN];
u8 src[ETH_ALEN];
-} __packed;
+};

union frameqos {
u16 shortdata;
--
2.39.2