2023-09-26 05:55:55

by Huqiang Qin

Subject: [PATCH V2 1/2] dt-bindings: watchdog: Add support for Amlogic C3 SoCs

Update dt-binding document for watchdog of Amlogic C3 SoCs.

Signed-off-by: Huqiang Qin <[email protected]>
---

V1 -> V2: Added compatibles.

.../devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
index 443e2e7ab467..b7e8e453c0ef 100644
--- a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
@@ -17,6 +17,7 @@ properties:
compatible:
enum:
- amlogic,meson-gxbb-wdt
+ - amlogic,c3-wdt
- amlogic,t7-wdt

reg:
--
2.42.0

2023-09-27 10:51:01

by Krzysztof Kozlowski

Subject: Re: [PATCH V2 1/2] dt-bindings: watchdog: Add support for Amlogic C3 SoCs

On 26/09/2023 07:55, Huqiang Qin wrote:
> Update dt-binding document for watchdog of Amlogic C3 SoCs.
>
> Signed-off-by: Huqiang Qin <[email protected]>
> ---
>
> V1 -> V2: Added compatibles.
>
> .../devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> index 443e2e7ab467..b7e8e453c0ef 100644
> --- a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> enum:
> - amlogic,meson-gxbb-wdt
> + - amlogic,c3-wdt

Nothing improved... this won't even work :/

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof