2023-09-26 08:25:38

by Oded Gabbay

Subject: [PATCH 1/9] accel/habanalabs: minor cosmetics update to cpucp_if.h

- Update copyright years
- Align comments

Signed-off-by: Oded Gabbay <[email protected]>
---
include/linux/habanalabs/cpucp_if.h | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/include/linux/habanalabs/cpucp_if.h b/include/linux/habanalabs/cpucp_if.h
index 84d74c4ee4d3..86ea7c63a0d2 100644
--- a/include/linux/habanalabs/cpucp_if.h
+++ b/include/linux/habanalabs/cpucp_if.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0
*
- * Copyright 2020-2022 HabanaLabs, Ltd.
+ * Copyright 2020-2023 HabanaLabs, Ltd.
* All Rights Reserved.
*
*/
@@ -668,18 +668,15 @@ enum pq_init_status {
* Obsolete.
*
* CPUCP_PACKET_GENERIC_PASSTHROUGH -
- * Generic opcode for all firmware info that is only passed to host
- * through the LKD, without getting parsed there.
+ * Generic opcode for all firmware info that is only passed to host
+ * through the LKD, without getting parsed there.
*
* CPUCP_PACKET_ACTIVE_STATUS_SET -
* LKD sends FW indication whether device is free or in use, this indication is reported
* also to the BMC.
*
- * CPUCP_PACKET_REGISTER_INTERRUPTS -
- * Packet to register interrupts indicating LKD is ready to receive events from FW.
- *
* CPUCP_PACKET_SOFT_RESET -
- * Packet to perform soft-reset.
+ * Packet to perform soft-reset.
*
* CPUCP_PACKET_INTS_REGISTER -
* Packet to inform FW that queues have been established and LKD is ready to receive
@@ -750,9 +747,9 @@ enum cpucp_packet_id {
CPUCP_PACKET_RESERVED11, /* not used */
CPUCP_PACKET_RESERVED12, /* internal */
CPUCP_PACKET_RESERVED13, /* internal */
- CPUCP_PACKET_SOFT_RESET, /* internal */
- CPUCP_PACKET_INTS_REGISTER, /* internal */
- CPUCP_PACKET_ID_MAX /* must be last */
+ CPUCP_PACKET_SOFT_RESET, /* internal */
+ CPUCP_PACKET_INTS_REGISTER, /* internal */
+ CPUCP_PACKET_ID_MAX /* must be last */
};

#define CPUCP_PACKET_FENCE_VAL 0xFE8CE7A5
--
2.34.1

2023-09-26 08:25:41

by Oded Gabbay

Subject: [PATCH 2/9] accel/habanalabs: minor cosmetics update to trace file

- Update copyright years
- Add missing newline at end of file

Signed-off-by: Oded Gabbay <[email protected]>
---
include/trace/events/habanalabs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/habanalabs.h b/include/trace/events/habanalabs.h
index 0d3667399d01..cf85753a33b1 100644
--- a/include/trace/events/habanalabs.h
+++ b/include/trace/events/habanalabs.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0
*
- * Copyright 2016-2021 HabanaLabs, Ltd.
+ * Copyright 2022-2023 HabanaLabs, Ltd.
* All Rights Reserved.
*
*/
@@ -209,3 +209,4 @@ DEFINE_EVENT(habanalabs_reg_access_template, habanalabs_elbi_write,

/* This part must be outside protection */
#include <trace/define_trace.h>
+
--
2.34.1

2023-09-26 08:25:47

by Oded Gabbay

Subject: [PATCH 5/9] accel/habanalabs: remove unused field

flags in struct wait_interrupt_data is not used anywhere so remove it.

Signed-off-by: Oded Gabbay <[email protected]>
---
drivers/accel/habanalabs/common/command_submission.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c
index 751d2c7d3fb8..e5ca490b7fca 100644
--- a/drivers/accel/habanalabs/common/command_submission.c
+++ b/drivers/accel/habanalabs/common/command_submission.c
@@ -47,7 +47,6 @@ struct wait_interrupt_data {
u64 cq_offset;
u64 target_value;
u64 intr_timeout_us;
- unsigned long flags;
};

static void job_wq_completion(struct work_struct *work);
--
2.34.1

2023-10-01 15:35:52

by Ofir Bitton

Subject: Re: [PATCH 1/9] accel/habanalabs: minor cosmetics update to cpucp_if.h

On 26/09/2023 11:13, Oded Gabbay wrote:
> - Update copyright years
> - Align comments
>
> Signed-off-by: Oded Gabbay <[email protected]>
> ---
> include/linux/habanalabs/cpucp_if.h | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/habanalabs/cpucp_if.h b/include/linux/habanalabs/cpucp_if.h
> index 84d74c4ee4d3..86ea7c63a0d2 100644
> --- a/include/linux/habanalabs/cpucp_if.h
> +++ b/include/linux/habanalabs/cpucp_if.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0
> *
> - * Copyright 2020-2022 HabanaLabs, Ltd.
> + * Copyright 2020-2023 HabanaLabs, Ltd.
> * All Rights Reserved.
> *
> */
> @@ -668,18 +668,15 @@ enum pq_init_status {
> * Obsolete.
> *
> * CPUCP_PACKET_GENERIC_PASSTHROUGH -
> - * Generic opcode for all firmware info that is only passed to host
> - * through the LKD, without getting parsed there.
> + * Generic opcode for all firmware info that is only passed to host
> + * through the LKD, without getting parsed there.
> *
> * CPUCP_PACKET_ACTIVE_STATUS_SET -
> * LKD sends FW indication whether device is free or in use, this indication is reported
> * also to the BMC.
> *
> - * CPUCP_PACKET_REGISTER_INTERRUPTS -
> - * Packet to register interrupts indicating LKD is ready to receive events from FW.
> - *
> * CPUCP_PACKET_SOFT_RESET -
> - * Packet to perform soft-reset.
> + * Packet to perform soft-reset.
> *
> * CPUCP_PACKET_INTS_REGISTER -
> * Packet to inform FW that queues have been established and LKD is ready to receive
> @@ -750,9 +747,9 @@ enum cpucp_packet_id {
> CPUCP_PACKET_RESERVED11, /* not used */
> CPUCP_PACKET_RESERVED12, /* internal */
> CPUCP_PACKET_RESERVED13, /* internal */
> - CPUCP_PACKET_SOFT_RESET, /* internal */
> - CPUCP_PACKET_INTS_REGISTER, /* internal */
> - CPUCP_PACKET_ID_MAX /* must be last */
> + CPUCP_PACKET_SOFT_RESET, /* internal */
> + CPUCP_PACKET_INTS_REGISTER, /* internal */
> + CPUCP_PACKET_ID_MAX /* must be last */
> };
>
> #define CPUCP_PACKET_FENCE_VAL 0xFE8CE7A5

Ack for the whole series.

Reviewed-by: Ofir Bitton <[email protected]>