2023-09-26 19:48:12

by Tim Harvey

[permalink] [raw]
Subject: [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible

Fix the imx8mm-venice-gw72xx-0x-rpidsi dt overlay compatible string
which should be gw,imx8mm-gw72xx-0x.

Fixes: 6b4da1354fd8 ("arm64: dts: imx8mm: add imx8mm-venice-gw72xx-0x-rpidsi overlay for display")
Signed-off-by: Tim Harvey <[email protected]>
---
.../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
index e0768d408c3b..2e4156b58108 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
@@ -11,7 +11,7 @@
/plugin/;

&{/} {
- compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm";
+ compatible = "gw,imx8mm-gw72xx-0x", "fsl,imx8mm";

panel {
compatible = "powertip,ph800480t013-idf02";
--
2.25.1


2023-09-26 20:12:04

by Ahmad Fatoum

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible

Hello Tim,

On 26.09.23 21:44, Tim Harvey wrote:
> Fix the imx8mm-venice-gw72xx-0x-rpidsi dt overlay compatible string
> which should be gw,imx8mm-gw72xx-0x.
>
> Fixes: 6b4da1354fd8 ("arm64: dts: imx8mm: add imx8mm-venice-gw72xx-0x-rpidsi overlay for display")
> Signed-off-by: Tim Harvey <[email protected]>
> ---
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> index e0768d408c3b..2e4156b58108 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> @@ -11,7 +11,7 @@
> /plugin/;
>
> &{/} {
> - compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm";
> + compatible = "gw,imx8mm-gw72xx-0x", "fsl,imx8mm";

Do you really want to fix up the compatible in the kernel device tree or was this
meant as a compatible for the overlay itself?

If it's the latter, you want to change above &{/} into / and use &{/}
only for the actual fragments below.

Cheers,
Ahmad


>
> panel {
> compatible = "powertip,ph800480t013-idf02";

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |