Some interfaces are common across RDPs. Move the common nodes to
ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
dts file to include interfaces that vary across RDPs. For instance, IPQ9574
has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
enables PCIE1, PCIE2 and PCIE3.
With the introduction of the common RDP DTSI,
- RDP433 gains SPI NOR support
- All the IPQ9574 RDPs gains USB2 and USB3 support
While at it, add support for WPS buttons.
Since Anusha's is busy and can't take up this series right now, I'm
stepping up to work on this series.
Changes in V3:
- Reworded the cover letter to indicate the need and advantages
of common RDP DTSI
- Change logs are in respective patches
- V2: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes in V2:
- Detailed change logs are added to the respective patches.
- V1: https://lore.kernel.org/linux-arm-msm/[email protected]/
---
Anusha Rao (2):
arm64: dts: qcom: ipq9574: Add common RDP dtsi file
arm64: dts: qcom: ipq9574: Enable WPS buttons
arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 147 +++++++++++++++++++++++
arch/arm64/boot/dts/qcom/ipq9574-rdp418.dts | 63 +---------
arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 91 +-------------
arch/arm64/boot/dts/qcom/ipq9574-rdp449.dts | 65 +---------
arch/arm64/boot/dts/qcom/ipq9574-rdp453.dts | 65 +---------
arch/arm64/boot/dts/qcom/ipq9574-rdp454.dts | 66 +---------
6 files changed, 152 insertions(+), 345 deletions(-)
---
base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f
change-id: 20230927-common-rdp-52f90fd0fd77
Best regards,
--
Kathiravan Thirumoorthy <[email protected]>
From: Anusha Rao <[email protected]>
Add support for wps buttons on GPIO 37.
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Anusha Rao <[email protected]>
Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
Changes in V3:
- None
Changes in V2:
- Removed linux,input-type from button-wps.
- Picked up Reviewed-by tag.
---
arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index 40a7aefd0540..49c9b6478357 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -8,6 +8,8 @@
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
#include "ipq9574.dtsi"
/ {
@@ -36,6 +38,19 @@ regulator_fixed_0p925: s0925 {
regulator-always-on;
regulator-name = "fixed_0p925";
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&gpio_keys_default>;
+ pinctrl-names = "default";
+
+ button-wps {
+ label = "wps";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&tlmm 37 GPIO_ACTIVE_LOW>;
+ debounce-interval = <60>;
+ };
+ };
};
&blsp1_spi0 {
@@ -95,6 +110,13 @@ spi_0_pins: spi-0-state {
drive-strength = <8>;
bias-disable;
};
+
+ gpio_keys_default: gpio-keys-default-state {
+ pins = "gpio37";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
};
&usb_0_dwc3 {
--
2.34.1
On 9/27/2023 12:13 PM, Kathiravan Thirumoorthy wrote:
> Some interfaces are common across RDPs. Move the common nodes to
> ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
> dts file to include interfaces that vary across RDPs. For instance, IPQ9574
> has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
> enables PCIE1, PCIE2 and PCIE3.
>
> With the introduction of the common RDP DTSI,
> - RDP433 gains SPI NOR support
> - All the IPQ9574 RDPs gains USB2 and USB3 support
>
> While at it, add support for WPS buttons.
>
> Since Anusha's is busy and can't take up this series right now, I'm
> stepping up to work on this series.
Gentle Reminder...
>
> Changes in V3:
> - Reworded the cover letter to indicate the need and advantages
> of common RDP DTSI
> - Change logs are in respective patches
> - V2: https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Changes in V2:
> - Detailed change logs are added to the respective patches.
> - V1: https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> ---
> Anusha Rao (2):
> arm64: dts: qcom: ipq9574: Add common RDP dtsi file
> arm64: dts: qcom: ipq9574: Enable WPS buttons
>
> arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 147 +++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/ipq9574-rdp418.dts | 63 +---------
> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 91 +-------------
> arch/arm64/boot/dts/qcom/ipq9574-rdp449.dts | 65 +---------
> arch/arm64/boot/dts/qcom/ipq9574-rdp453.dts | 65 +---------
> arch/arm64/boot/dts/qcom/ipq9574-rdp454.dts | 66 +---------
> 6 files changed, 152 insertions(+), 345 deletions(-)
> ---
> base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f
> change-id: 20230927-common-rdp-52f90fd0fd77
>
> Best regards,
On Wed, 27 Sep 2023 12:13:17 +0530, Kathiravan Thirumoorthy wrote:
> Some interfaces are common across RDPs. Move the common nodes to
> ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
> dts file to include interfaces that vary across RDPs. For instance, IPQ9574
> has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
> enables PCIE1, PCIE2 and PCIE3.
>
> With the introduction of the common RDP DTSI,
> - RDP433 gains SPI NOR support
> - All the IPQ9574 RDPs gains USB2 and USB3 support
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: ipq9574: Add common RDP dtsi file
commit: 0e8527d076cfb3fa55777a2ece735852fcf3e850
[2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons
commit: 0e2f2c506f01abcec412ccf91ed39ddfafbda60a
Best regards,
--
Bjorn Andersson <[email protected]>