2023-09-27 03:54:16

by Yang Li

Subject: [PATCH -next] ARM: shmobile: Remove unneeded semicolon

./arch/arm/mach-shmobile/smp-sh73a0.c:52:2-3: Unneeded semicolon
./arch/arm/mach-shmobile/smp-r8a7779.c:46:2-3: Unneeded semicolon
./arch/arm/mach-shmobile/pm-rcar-gen2.c:58:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6704
Signed-off-by: Yang Li <[email protected]>
---
arch/arm/mach-shmobile/pm-rcar-gen2.c | 2 +-
arch/arm/mach-shmobile/smp-r8a7779.c | 2 +-
arch/arm/mach-shmobile/smp-sh73a0.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c
index 3453d5733224..907a4f8c5aed 100644
--- a/arch/arm/mach-shmobile/pm-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c
@@ -55,7 +55,7 @@ void __init rcar_gen2_pm_init(void)
if (!request_mem_region(0, SZ_256K, "Boot Area")) {
pr_err("Failed to request boot area\n");
return;
- };
+ }

for_each_of_cpu_node(np) {
if (of_device_is_compatible(np, "arm,cortex-a15"))
diff --git a/arch/arm/mach-shmobile/smp-r8a7779.c b/arch/arm/mach-shmobile/smp-r8a7779.c
index 2b1b8248450c..474c325323a3 100644
--- a/arch/arm/mach-shmobile/smp-r8a7779.c
+++ b/arch/arm/mach-shmobile/smp-r8a7779.c
@@ -43,7 +43,7 @@ static void __init r8a7779_smp_prepare_cpus(unsigned int max_cpus)
if (!request_mem_region(0, SZ_4K, "Boot Area")) {
pr_err("Failed to request boot area\n");
return;
- };
+ }

base = ioremap(HPBREG_BASE, 0x1000);

diff --git a/arch/arm/mach-shmobile/smp-sh73a0.c b/arch/arm/mach-shmobile/smp-sh73a0.c
index 3757aed64c42..9196b37ea292 100644
--- a/arch/arm/mach-shmobile/smp-sh73a0.c
+++ b/arch/arm/mach-shmobile/smp-sh73a0.c
@@ -49,7 +49,7 @@ static void __init sh73a0_smp_prepare_cpus(unsigned int max_cpus)
if (!request_mem_region(0, SZ_4K, "Boot Area")) {
pr_err("Failed to request boot area\n");
return;
- };
+ }

/* Map the reset vector (in headsmp.S) */
ap = ioremap(AP_BASE, PAGE_SIZE);
--
2.20.1.7.g153144c

2023-09-27 10:24:58

by Geert Uytterhoeven

Subject: Re: [PATCH -next] ARM: shmobile: Remove unneeded semicolon

Hi Yang,

On Wed, Sep 27, 2023 at 3:02 AM Yang Li <[email protected]> wrote:
> ./arch/arm/mach-shmobile/smp-sh73a0.c:52:2-3: Unneeded semicolon
> ./arch/arm/mach-shmobile/smp-r8a7779.c:46:2-3: Unneeded semicolon
> ./arch/arm/mach-shmobile/pm-rcar-gen2.c:58:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6704
> Signed-off-by: Yang Li <[email protected]>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <[email protected]>

As the offending commits are not yet upstream, I will fold the fixes
into the existing commits.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds