2023-09-27 16:50:05

by Kumar, Udit

[permalink] [raw]
Subject: Re: [PATCH v4 0/9] Add R5F and C7x DSP node for K3 J721S2, AM68 and AM69 SoCs


On 9/6/2023 4:54 PM, Apurva Nandan wrote:
> This series adds the R5F processor nodes and C7x DSP nodes for
> J721S2, AM68 and AM69 SoCs to align these nodes with other K3 SOC's node.
>
> The first three patches adds the remote proc nodes to the SoC device
> tree, remaining patches reserves the memory for remote proc IPCs
> on K3 J721S2 EVM, AM68 SK, AM69 boards.
>
> Note, K3 AM69 SoC derives from K3 J784S4 SoC, but is included in this
> series as it was originally missed in the K3 J784S4 EVM rproc series.
> (https://lore.kernel.org/all/[email protected]/).
>
> kpv log: https://gist.githubusercontent.com/apurvanandan1997/57fcf127c118a48bd174ce36d8840329/raw/
> Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/

You need to rebase the series

For patches 6/9, 7/9, 8/9 and 9/9

Reviewed by: Udit Kumar <[email protected]>

>
> v4: Changelog:
> 1) Added R5F and C7x nodes for K3 AM68 and AM69 SoCs
>
> Link to v3:
> https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> v3: Changelog:
> 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
> which fixes the following dtbs_check for k3-am69-sk.dts
> - dsp@64800000: 'mboxes' is a required property
> - dsp@64800000: 'memory-region' is a required property
> 2) Split into separate patches for C7x and R5F
>
> Link to v2:
> https://lore.kernel.org/lkml/[email protected]/
>
> v2:Changelog:
> 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
> 2) Fixed mboxes property in for all cores in som dts
>
> Link to v1:
> https://lore.kernel.org/all/[email protected]/
>
>
> Apurva Nandan (9):
> arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes
> arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
> arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
> arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> R5F
> arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> C71x DSPs
> arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for R5F
> arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for
> C71x DSP
> arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for R5F
> arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for C71x
> DSP
>
> arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 208 ++++++++++++
> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 304 ++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 106 ++++++
> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++
> arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 208 ++++++++++++
> 5 files changed, 866 insertions(+)
>


2023-09-27 21:28:24

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v4 0/9] Add R5F and C7x DSP node for K3 J721S2, AM68 and AM69 SoCs

On 14:24-20230927, Kumar, Udit wrote:
>
> On 9/6/2023 4:54 PM, Apurva Nandan wrote:
> > This series adds the R5F processor nodes and C7x DSP nodes for
> > J721S2, AM68 and AM69 SoCs to align these nodes with other K3 SOC's node.
> >
> > The first three patches adds the remote proc nodes to the SoC device
> > tree, remaining patches reserves the memory for remote proc IPCs
> > on K3 J721S2 EVM, AM68 SK, AM69 boards.
> >
> > Note, K3 AM69 SoC derives from K3 J784S4 SoC, but is included in this
> > series as it was originally missed in the K3 J784S4 EVM rproc series.
> > (https://lore.kernel.org/all/[email protected]/).
> >
> > kpv log: https://gist.githubusercontent.com/apurvanandan1997/57fcf127c118a48bd174ce36d8840329/raw/
> > Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/
>
> You need to rebase the series
>
> For patches 6/9, 7/9, 8/9 and 9/9
>
> Reviewed by: Udit Kumar <[email protected]>

Please provide reviewed by for the exact patches than expecting
maintainers to pick the reviewed bys.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D