2023-09-28 10:11:22

by Jiapeng Chong

Subject: [PATCH] drm/radeon/kms/atom: Remove redundant code

drivers/gpu/drm/radeon/atom.c:396 atom_skip_src_int() warn: ignoring unreachable code.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6713
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/radeon/atom.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
index ceb6d772ef94..3082d08a06c2 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -393,7 +393,6 @@ static void atom_skip_src_int(atom_exec_context *ctx, uint8_t attr, int *ptr)
(*ptr)++;
return;
}
- return;
}
}

--
2.20.1.7.g153144c

2023-09-30 14:51:35

by Alex Deucher

Subject: Re: [PATCH] drm/radeon/kms/atom: Remove redundant code

On Thu, Sep 28, 2023 at 5:46 AM Jiapeng Chong
<[email protected]> wrote:
>
> drivers/gpu/drm/radeon/atom.c:396 atom_skip_src_int() warn: ignoring unreachable code.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6713
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpu/drm/radeon/atom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> index ceb6d772ef94..3082d08a06c2 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -393,7 +393,6 @@ static void atom_skip_src_int(atom_exec_context *ctx, uint8_t attr, int *ptr)
> (*ptr)++;
> return;
> }
> - return;

I think this should be a break.

Alex

> }
> }
>
> --
> 2.20.1.7.g153144c
>