2023-09-29 20:29:57

by David Lechner

Subject: [PATCH v3 03/27] staging: iio: resolver: ad2s1210: remove call to spi_setup()

From: David Lechner <[email protected]>

From: David Lechner <[email protected]>

This removes the call to spi_setup() in the ad2s1210 driver.

Setting MODE_3 was incorrect. It should be MODE_1 but we can let the
device tree select this and avoid the need to call spi_setup().

Signed-off-by: David Lechner <[email protected]>
---

v3 changes:
* This is a new patch split out from "staging: iio: resolver: ad2s1210:
fix probe"

drivers/staging/iio/resolver/ad2s1210.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index 3f08b59f4e19..8fde08887f7f 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -683,8 +683,6 @@ static int ad2s1210_probe(struct spi_device *spi)
return ret;

st->fclkin = spi->max_speed_hz;
- spi->mode = SPI_MODE_3;
- spi_setup(spi);
ad2s1210_initial(st);

return 0;

--
2.42.0

2023-09-30 14:38:59

by Jonathan Cameron

Subject: Re: [PATCH v3 03/27] staging: iio: resolver: ad2s1210: remove call to spi_setup()

On Fri, 29 Sep 2023 12:23:08 -0500
David Lechner <[email protected]> wrote:

> From: David Lechner <[email protected]>
>
> From: David Lechner <[email protected]>
>
> This removes the call to spi_setup() in the ad2s1210 driver.
>
> Setting MODE_3 was incorrect. It should be MODE_1 but we can let the
> device tree select this and avoid the need to call spi_setup().
>
> Signed-off-by: David Lechner <[email protected]>

Applied and pushed out as testing for all the normal reasons.

Thanks,

Jonathan

> ---
>
> v3 changes:
> * This is a new patch split out from "staging: iio: resolver: ad2s1210:
> fix probe"
>
> drivers/staging/iio/resolver/ad2s1210.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 3f08b59f4e19..8fde08887f7f 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -683,8 +683,6 @@ static int ad2s1210_probe(struct spi_device *spi)
> return ret;
>
> st->fclkin = spi->max_speed_hz;
> - spi->mode = SPI_MODE_3;
> - spi_setup(spi);
> ad2s1210_initial(st);
>
> return 0;
>