2023-09-29 04:45:29

by Anjelique Melendez

Subject: [PATCH v5 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG

Update the pmi632 lpg_data struct so that pmi632 devices use PPG
for LUT pattern.

Signed-off-by: Anjelique Melendez <[email protected]>
---
drivers/leds/rgb/leds-qcom-lpg.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index 4d87686f916c..a6cea6bd7167 100644
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -1660,11 +1660,13 @@ static const struct lpg_data pm8994_lpg_data = {
static const struct lpg_data pmi632_lpg_data = {
.triled_base = 0xd000,

+ .lut_size = 64,
+
.num_channels = 5,
.channels = (const struct lpg_channel_data[]) {
- { .base = 0xb300, .triled_mask = BIT(7) },
- { .base = 0xb400, .triled_mask = BIT(6) },
- { .base = 0xb500, .triled_mask = BIT(5) },
+ { .base = 0xb300, .triled_mask = BIT(7), .sdam_offset = 0x48 },
+ { .base = 0xb400, .triled_mask = BIT(6), .sdam_offset = 0x56 },
+ { .base = 0xb500, .triled_mask = BIT(5), .sdam_offset = 0x64 },
{ .base = 0xb600 },
{ .base = 0xb700 },
},
--
2.41.0

2023-10-05 16:02:46

by Lee Jones

Subject: Re: [PATCH v5 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG

On Thu, 28 Sep 2023, Anjelique Melendez wrote:

> Update the pmi632 lpg_data struct so that pmi632 devices use PPG
> for LUT pattern.
>
> Signed-off-by: Anjelique Melendez <[email protected]>
> ---
> drivers/leds/rgb/leds-qcom-lpg.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Lee Jones <[email protected]>

> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index 4d87686f916c..a6cea6bd7167 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -1660,11 +1660,13 @@ static const struct lpg_data pm8994_lpg_data = {
> static const struct lpg_data pmi632_lpg_data = {
> .triled_base = 0xd000,
>
> + .lut_size = 64,
> +
> .num_channels = 5,
> .channels = (const struct lpg_channel_data[]) {
> - { .base = 0xb300, .triled_mask = BIT(7) },
> - { .base = 0xb400, .triled_mask = BIT(6) },
> - { .base = 0xb500, .triled_mask = BIT(5) },
> + { .base = 0xb300, .triled_mask = BIT(7), .sdam_offset = 0x48 },
> + { .base = 0xb400, .triled_mask = BIT(6), .sdam_offset = 0x56 },
> + { .base = 0xb500, .triled_mask = BIT(5), .sdam_offset = 0x64 },
> { .base = 0xb600 },
> { .base = 0xb700 },
> },
> --
> 2.41.0
>

--
Lee Jones [李琼斯]