2023-09-30 15:36:16

by Jonathan Bergh

[permalink] [raw]
Subject: [PATCH 1/3] drivers: acpi: Fix pointer declarations in parameter lists which included whitespace spuriously

Fixed issues where pointer declarations in parameter lists included
whitespace before the parameter names and should not.

Signed-off-by: Jonathan Bergh <[email protected]>
---
drivers/acpi/osl.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index f725813d0cce..29e0005c30aa 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -493,7 +493,7 @@ EXPORT_SYMBOL(acpi_os_unmap_generic_address);

#ifdef ACPI_FUTURE_USAGE
acpi_status
-acpi_os_get_physical_address(void *virt, acpi_physical_address * phys)
+acpi_os_get_physical_address(void *virt, acpi_physical_address *phys)
{
if (!phys || !virt)
return AE_BAD_PARAMETER;
@@ -784,7 +784,7 @@ acpi_os_write_memory(acpi_physical_address phys_addr, u64 value, u32 width)

#ifdef CONFIG_PCI
acpi_status
-acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
+acpi_os_read_pci_configuration(struct acpi_pci_id *pci_id, u32 reg,
u64 *value, u32 width)
{
int result, size;
@@ -816,7 +816,7 @@ acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
}

acpi_status
-acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
+acpi_os_write_pci_configuration(struct acpi_pci_id *pci_id, u32 reg,
u64 value, u32 width)
{
int result, size;
@@ -1197,7 +1197,7 @@ bool acpi_queue_hotplug_work(struct work_struct *work)
}

acpi_status
-acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle * handle)
+acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle *handle)
{
struct semaphore *sem = NULL;

@@ -1554,7 +1554,7 @@ void acpi_os_release_lock(acpi_spinlock lockp, acpi_cpu_flags flags)
******************************************************************************/

acpi_status
-acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
+acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t **cache)
{
*cache = kmem_cache_create(name, size, 0, 0, NULL);
if (*cache == NULL)
@@ -1575,7 +1575,7 @@ acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
*
******************************************************************************/

-acpi_status acpi_os_purge_cache(acpi_cache_t * cache)
+acpi_status acpi_os_purge_cache(acpi_cache_t *cache)
{
kmem_cache_shrink(cache);
return (AE_OK);
@@ -1594,7 +1594,7 @@ acpi_status acpi_os_purge_cache(acpi_cache_t * cache)
*
******************************************************************************/

-acpi_status acpi_os_delete_cache(acpi_cache_t * cache)
+acpi_status acpi_os_delete_cache(acpi_cache_t *cache)
{
kmem_cache_destroy(cache);
return (AE_OK);
@@ -1614,7 +1614,7 @@ acpi_status acpi_os_delete_cache(acpi_cache_t * cache)
*
******************************************************************************/

-acpi_status acpi_os_release_object(acpi_cache_t * cache, void *object)
+acpi_status acpi_os_release_object(acpi_cache_t *cache, void *object)
{
kmem_cache_free(cache, object);
return (AE_OK);
--
2.34.1


2023-10-03 18:30:38

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH 1/3] drivers: acpi: Fix pointer declarations in parameter lists which included whitespace spuriously

On Sat, Sep 30, 2023 at 11:03 AM Jonathan Bergh
<[email protected]> wrote:
>
> Fixed issues where pointer declarations in parameter lists included
> whitespace before the parameter names and should not.
>
> Signed-off-by: Jonathan Bergh <[email protected]>
> ---
> drivers/acpi/osl.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index f725813d0cce..29e0005c30aa 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -493,7 +493,7 @@ EXPORT_SYMBOL(acpi_os_unmap_generic_address);
>
> #ifdef ACPI_FUTURE_USAGE
> acpi_status
> -acpi_os_get_physical_address(void *virt, acpi_physical_address * phys)
> +acpi_os_get_physical_address(void *virt, acpi_physical_address *phys)
> {
> if (!phys || !virt)
> return AE_BAD_PARAMETER;
> @@ -784,7 +784,7 @@ acpi_os_write_memory(acpi_physical_address phys_addr, u64 value, u32 width)
>
> #ifdef CONFIG_PCI
> acpi_status
> -acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
> +acpi_os_read_pci_configuration(struct acpi_pci_id *pci_id, u32 reg,
> u64 *value, u32 width)
> {
> int result, size;
> @@ -816,7 +816,7 @@ acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
> }
>
> acpi_status
> -acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
> +acpi_os_write_pci_configuration(struct acpi_pci_id *pci_id, u32 reg,
> u64 value, u32 width)
> {
> int result, size;
> @@ -1197,7 +1197,7 @@ bool acpi_queue_hotplug_work(struct work_struct *work)
> }
>
> acpi_status
> -acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle * handle)
> +acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle *handle)
> {
> struct semaphore *sem = NULL;
>
> @@ -1554,7 +1554,7 @@ void acpi_os_release_lock(acpi_spinlock lockp, acpi_cpu_flags flags)
> ******************************************************************************/
>
> acpi_status
> -acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
> +acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t **cache)
> {
> *cache = kmem_cache_create(name, size, 0, 0, NULL);
> if (*cache == NULL)
> @@ -1575,7 +1575,7 @@ acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
> *
> ******************************************************************************/
>
> -acpi_status acpi_os_purge_cache(acpi_cache_t * cache)
> +acpi_status acpi_os_purge_cache(acpi_cache_t *cache)
> {
> kmem_cache_shrink(cache);
> return (AE_OK);
> @@ -1594,7 +1594,7 @@ acpi_status acpi_os_purge_cache(acpi_cache_t * cache)
> *
> ******************************************************************************/
>
> -acpi_status acpi_os_delete_cache(acpi_cache_t * cache)
> +acpi_status acpi_os_delete_cache(acpi_cache_t *cache)
> {
> kmem_cache_destroy(cache);
> return (AE_OK);
> @@ -1614,7 +1614,7 @@ acpi_status acpi_os_delete_cache(acpi_cache_t * cache)
> *
> ******************************************************************************/
>
> -acpi_status acpi_os_release_object(acpi_cache_t * cache, void *object)
> +acpi_status acpi_os_release_object(acpi_cache_t *cache, void *object)
> {
> kmem_cache_free(cache, object);
> return (AE_OK);
> --

Applied along with the [2-3/3] as 6.7 material with edits in the
subjects and changelogs.

Thanks!