2023-09-26 16:45:57

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes

"additionalProperties: true" is only for incomplete schemas such as bus
child nodes in a bus's schema. That doesn't apply to the "channel" nodes
in the adi,ad7292 binding, so fix additionalProperties to be false.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
index 7cc4ddc4e9b7..2aa1f4b063eb 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
@@ -61,7 +61,7 @@ patternProperties:
required:
- reg

- additionalProperties: true
+ additionalProperties: false

allOf:
- $ref: /schemas/spi/spi-peripheral-props.yaml#
--
2.40.1


2023-09-27 03:35:09

by Marcelo Schmitt

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes

On 09/26, Rob Herring wrote:
> "additionalProperties: true" is only for incomplete schemas such as bus
> child nodes in a bus's schema. That doesn't apply to the "channel" nodes
> in the adi,ad7292 binding, so fix additionalProperties to be false.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Marcelo Schmitt <[email protected]>

Thanks,
Marcelo

2023-09-27 15:22:59

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes

Acked-by: Conor Dooley <[email protected]>

Attachments:
(No filename) (53.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-09-30 16:47:04

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: adc: adi,ad7292: Fix additionalProperties on channel nodes

On Tue, 26 Sep 2023 11:43:50 -0500
Rob Herring <[email protected]> wrote:

> "additionalProperties: true" is only for incomplete schemas such as bus
> child nodes in a bus's schema. That doesn't apply to the "channel" nodes
> in the adi,ad7292 binding, so fix additionalProperties to be false.
>
> Signed-off-by: Rob Herring <[email protected]>
Oops.

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> index 7cc4ddc4e9b7..2aa1f4b063eb 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> @@ -61,7 +61,7 @@ patternProperties:
> required:
> - reg
>
> - additionalProperties: true
> + additionalProperties: false
>
> allOf:
> - $ref: /schemas/spi/spi-peripheral-props.yaml#