2023-10-02 14:03:13

by Andy Shevchenko

Subject: [PATCH v1 1/1] leds: tca6507: Don't use fixed GPIO base

First of all, the fixed GPIO base is source of troubles and
it doesn't scale. Second, there is no in-kernel user of this
base, so drop it.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/leds/leds-tca6507.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index aab861771210..e19074614095 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -92,9 +92,6 @@

struct tca6507_platform_data {
struct led_platform_data leds;
-#ifdef CONFIG_GPIOLIB
- int gpio_base;
-#endif
};

#define TCA6507_MAKE_GPIO 1
@@ -636,7 +633,7 @@ static int tca6507_probe_gpios(struct device *dev,

tca->gpio.label = "gpio-tca6507";
tca->gpio.ngpio = gpios;
- tca->gpio.base = pdata->gpio_base;
+ tca->gpio.base = -1;
tca->gpio.owner = THIS_MODULE;
tca->gpio.direction_output = tca6507_gpio_direction_output;
tca->gpio.set = tca6507_gpio_set_value;
@@ -715,9 +712,6 @@ tca6507_led_dt_init(struct device *dev)

pdata->leds.leds = tca_leds;
pdata->leds.num_leds = NUM_LEDS;
-#ifdef CONFIG_GPIOLIB
- pdata->gpio_base = -1;
-#endif

return pdata;
}
--
2.40.0.1.gaa8946217a0b

2023-10-05 15:15:52

by Lee Jones

Subject: Re: [PATCH v1 1/1] leds: tca6507: Don't use fixed GPIO base

On Mon, 02 Oct 2023 16:56:29 +0300, Andy Shevchenko wrote:
> First of all, the fixed GPIO base is source of troubles and
> it doesn't scale. Second, there is no in-kernel user of this
> base, so drop it.
>
>

Applied, thanks!

[1/1] leds: tca6507: Don't use fixed GPIO base
commit: ed84d55d5115455d17fa93f63dbf89697a309d6e

--
Lee Jones [李琼斯]

2023-10-05 16:16:19

by Lee Jones

Subject: Re: [PATCH v1 1/1] leds: tca6507: Don't use fixed GPIO base

On Thu, 05 Oct 2023, Lee Jones wrote:

> On Mon, 02 Oct 2023 16:56:29 +0300, Andy Shevchenko wrote:
> > First of all, the fixed GPIO base is source of troubles and
> > it doesn't scale. Second, there is no in-kernel user of this
> > base, so drop it.
> >
> >
>
> Applied, thanks!
>
> [1/1] leds: tca6507: Don't use fixed GPIO base
> commit: ed84d55d5115455d17fa93f63dbf89697a309d6e

Okay, looks like the (subset) issue has been fixed.

--
Lee Jones [李琼斯]