This patch set add USB device controller for the NPCM Baseboard
Management Controllers (BMC).
NPCM UDC driver is a part of the USB ChipIdea driver.
Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active
parameter to active in case the ChipIdea USB IP role is device-only and
there is no otgsc register.
BMC NPCM7XX and BMC NPCM8XX has ten identical NPCM UDC modules,
The NPCM UDC were tested on NPCM845 evaluation board.
Addressed comments from:
- Krzysztof Kozlowski : https://www.spinics.net/lists/kernel/msg4951321.html
Changes since version 2:
- Use dev_err_probe.
- Remove MODULE_ALIAS.
Changes since version 1:
- Add SoC specific compatible.
- Remove USB phy mux property from dt-binding, will be handled differently.
- Add CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS commit to this patch set.
Tomer Maimon (3):
usb: chipidea: add CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag
dt-bindings: usb: ci-hdrc-usb2: add npcm750 and npcm845 compatible
usb: chipidea: Add support for NPCM
.../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 +
drivers/usb/chipidea/Kconfig | 4 +
drivers/usb/chipidea/Makefile | 1 +
drivers/usb/chipidea/ci_hdrc_npcm.c | 114 ++++++++++++++++++
drivers/usb/chipidea/otg.c | 5 +-
include/linux/usb/chipidea.h | 1 +
6 files changed, 128 insertions(+), 1 deletion(-)
create mode 100644 drivers/usb/chipidea/ci_hdrc_npcm.c
--
2.33.0
Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845.
Signed-off-by: Tomer Maimon <[email protected]>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index 1394557517b1..a9e173432002 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -16,6 +16,8 @@ properties:
- enum:
- chipidea,usb2
- lsi,zevio-usb
+ - nuvoton,npcm750-udc
+ - nuvoton,npcm845-udc
- nvidia,tegra20-ehci
- nvidia,tegra20-udc
- nvidia,tegra30-ehci
@@ -388,6 +390,8 @@ allOf:
enum:
- chipidea,usb2
- lsi,zevio-usb
+ - nuvoton,npcm750-udc
+ - nuvoton,npcm845-udc
- nvidia,tegra20-udc
- nvidia,tegra30-udc
- nvidia,tegra114-udc
--
2.33.0
On Mon, Oct 02, 2023 at 07:13:47PM +0300, Tomer Maimon wrote:
> This patch set add USB device controller for the NPCM Baseboard
> Management Controllers (BMC).
>
> NPCM UDC driver is a part of the USB ChipIdea driver.
>
> Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active
> parameter to active in case the ChipIdea USB IP role is device-only and
> there is no otgsc register.
>
> BMC NPCM7XX and BMC NPCM8XX has ten identical NPCM UDC modules,
>
> The NPCM UDC were tested on NPCM845 evaluation board.
>
> Addressed comments from:
> - Krzysztof Kozlowski : https://www.spinics.net/lists/kernel/msg4951321.html
Why is this a RESEND?
Hi Greg,
Forgot to add in Acked-by: Peter Chen <[email protected]> in V3,
Resend the patch set with the Ack.
Should I do it differently?
On Tue, 3 Oct 2023 at 09:51, Greg KH <[email protected]> wrote:
>
> On Mon, Oct 02, 2023 at 07:13:47PM +0300, Tomer Maimon wrote:
> > This patch set add USB device controller for the NPCM Baseboard
> > Management Controllers (BMC).
> >
> > NPCM UDC driver is a part of the USB ChipIdea driver.
> >
> > Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active
> > parameter to active in case the ChipIdea USB IP role is device-only and
> > there is no otgsc register.
> >
> > BMC NPCM7XX and BMC NPCM8XX has ten identical NPCM UDC modules,
> >
> > The NPCM UDC were tested on NPCM845 evaluation board.
> >
> > Addressed comments from:
> > - Krzysztof Kozlowski : https://www.spinics.net/lists/kernel/msg4951321.html
>
> Why is this a RESEND?
>
Thanks,
Tomer
On Tue, Oct 03, 2023 at 09:56:47AM +0300, Tomer Maimon wrote:
> Hi Greg,
>
> Forgot to add in Acked-by: Peter Chen <[email protected]> in V3,
> Resend the patch set with the Ack.
>
> Should I do it differently?
You need to tell me what the difference is, otherwise I would have no
clue what to do, what would you do if you had to review all of these and
try to figure out which ones to accept?
Please send this as a v4.
thanks,
greg k-h
O.K.
Thanks a lot
Tomer
On Tue, 3 Oct 2023 at 10:05, Greg KH <[email protected]> wrote:
>
> On Tue, Oct 03, 2023 at 09:56:47AM +0300, Tomer Maimon wrote:
> > Hi Greg,
> >
> > Forgot to add in Acked-by: Peter Chen <[email protected]> in V3,
> > Resend the patch set with the Ack.
> >
> > Should I do it differently?
>
> You need to tell me what the difference is, otherwise I would have no
> clue what to do, what would you do if you had to review all of these and
> try to figure out which ones to accept?
>
> Please send this as a v4.
>
> thanks,
>
> greg k-h
On 03/10/2023 08:56, Tomer Maimon wrote:
> Hi Greg,
>
> Forgot to add in Acked-by: Peter Chen <[email protected]> in V3,
> Resend the patch set with the Ack.
>
> Should I do it differently?
If it is RESEND after some time (min. 2 weeks), then it is fine. If you
added tags or changed something, make a new version. If you resend for
any other reason (assuming resend is valid), please mention shortly why
do you resend (e.g. "My company email servers maybe blocked it, so
resending without changes").
Best regards,
Krzysztof
Hi Krzysztof,
Appreciate your clarifications
Thanks,
Tomer
On Tue, 3 Oct 2023 at 11:32, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 03/10/2023 08:56, Tomer Maimon wrote:
> > Hi Greg,
> >
> > Forgot to add in Acked-by: Peter Chen <[email protected]> in V3,
> > Resend the patch set with the Ack.
> >
> > Should I do it differently?
>
> If it is RESEND after some time (min. 2 weeks), then it is fine. If you
> added tags or changed something, make a new version. If you resend for
> any other reason (assuming resend is valid), please mention shortly why
> do you resend (e.g. "My company email servers maybe blocked it, so
> resending without changes").
>
> Best regards,
> Krzysztof
>