2023-09-18 20:53:48

by swarup

Subject: [PATCH] usb: fix kernel-doc warning

Fix kernel-doc warnings discovered in usb driver.
Fixes this warning:
warning: Function parameter or member 'gfladj_refclk_lpm_sel'
not described in 'dwc3'

Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
---
drivers/usb/dwc3/core.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index a69ac67d89fe..078edfe0f88e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
* instances in park mode.
* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
* instances in park mode.
+ * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
+ * Global Frame Length Adjustment register
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
--
2.34.1

2023-10-02 18:26:07

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: fix kernel-doc warning

On Mon, Oct 02, 2023 at 09:10:30PM +0530, swarup wrote:
> On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> > On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > > Fix kernel-doc warnings discovered in usb driver.
> > > Fixes this warning:
> > > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > > not described in 'dwc3'
> > >
> > > Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
> > > ---
> > > drivers/usb/dwc3/core.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > What commit id does this fix?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
> Please find the commit id as mentioned below,
> next time onwards i will mention it:
>
> Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")

That is not a valid commit id in Linus's tree, are you sure it is
correct?

And please resend the patch with that information in it.

thanks,

greg k-h

2023-10-02 19:19:31

by swarup

Subject: Re: [PATCH] usb: fix kernel-doc warning

esOn Mon, Oct 02, 2023 at 05:46:49PM +0200, Greg KH wrote:
> On Mon, Oct 02, 2023 at 09:10:30PM +0530, swarup wrote:
> > On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> > > On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > > > Fix kernel-doc warnings discovered in usb driver.
> > > > Fixes this warning:
> > > > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > > > not described in 'dwc3'
> > > >
> > > > Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
> > > > ---
> > > > drivers/usb/dwc3/core.h | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > What commit id does this fix?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi Greg,
> > Please find the commit id as mentioned below,
> > next time onwards i will mention it:
> >
> > Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")
>
> That is not a valid commit id in Linus's tree, are you sure it is
> correct?
>
> And please resend the patch with that information in it.
>
> thanks,
>
> greg k-h

Hi Greg,
I send patch V2, with the Fixes tag being mentioned.
Please check the email.
Thanks,
Swarup

2023-10-02 22:25:59

by swarup

Subject: Re: [PATCH] usb: fix kernel-doc warning

On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > Fix kernel-doc warnings discovered in usb driver.
> > Fixes this warning:
> > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > not described in 'dwc3'
> >
> > Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
> > ---
> > drivers/usb/dwc3/core.h | 2 ++
> > 1 file changed, 2 insertions(+)
>
> What commit id does this fix?
>
> thanks,
>
> greg k-h

Hi Greg,
Please find the commit id as mentioned below,
next time onwards i will mention it:

Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")

Thanks,
Swarup

2023-10-02 22:35:55

by swarup

Subject: [PATCH v2] usb: fix kernel-doc warning

Fix kernel-doc warnings discovered in usb driver.

Fixes this warning:
warning: Function parameter or member 'gfladj_refclk_lpm_sel'
not described in 'dwc3'

Fixes: cf1202418e0b ("usb: fix kernel-doc warning")
Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
---
drivers/usb/dwc3/core.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index a69ac67d89fe..078edfe0f88e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
* instances in park mode.
* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
* instances in park mode.
+ * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
+ * Global Frame Length Adjustment register
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
--
2.34.1

2023-10-02 22:41:10

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: fix kernel-doc warning

On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> Fix kernel-doc warnings discovered in usb driver.
> Fixes this warning:
> warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> not described in 'dwc3'
>
> Signed-off-by: Swarup Laxman Kotiaklapudi <[email protected]>
> ---
> drivers/usb/dwc3/core.h | 2 ++
> 1 file changed, 2 insertions(+)

What commit id does this fix?

thanks,

greg k-h