2023-10-04 08:55:18

by Tony Lindgren

Subject: [PATCH] printk: Check valid console index for preferred console

Let's check for valid console index values.

Signed-off-by: Tony Lindgren <[email protected]>
---
kernel/printk/printk.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2410,6 +2410,10 @@ static int __add_preferred_console(char *name, int idx, char *options,
struct console_cmdline *c;
int i;

+ /* See struct console */
+ if (idx > SHRT_MAX)
+ return -EINVAL;
+
/*
* See if this tty is not yet registered, and
* if we have a slot free.
--
2.42.0

2023-10-11 07:34:19

by Tony Lindgren

Subject: Re: [PATCH] printk: Check valid console index for preferred console

* Tony Lindgren <[email protected]> [700101 02:00]:
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2410,6 +2410,10 @@ static int __add_preferred_console(char *name, int idx, char *options,
> struct console_cmdline *c;
> int i;
>
> + /* See struct console */
> + if (idx > SHRT_MAX)
> + return -EINVAL;
> +

We can just use const short idx for preferred console and return an error
for negative values for preferred console. I'll send out v2 patch.

Regards,

Tony