2023-10-05 14:09:25

by AKASHI Takahiro

Subject: [RFC v2 2/5] pinctrl: always export pin_config_get_for_pin()

This function will be used to implement a new pinctrl_gpio_get_config()
outside pinconf.c in a succeeding commit.
So make it always visible to avoid a kernel test bot error.

Signed-off-by: AKASHI Takahiro <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
RFC v2 (Oct 5, 2023)
* new
---
drivers/pinctrl/pinconf.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h
index 694bfc9961fa..068089b199e4 100644
--- a/drivers/pinctrl/pinconf.h
+++ b/drivers/pinctrl/pinconf.h
@@ -31,13 +31,13 @@ int pinconf_apply_setting(const struct pinctrl_setting *setting);

int pinconf_set_config(struct pinctrl_dev *pctldev, unsigned pin,
unsigned long *configs, size_t nconfigs);
+int pin_config_get_for_pin(struct pinctrl_dev *pctldev, unsigned pin,
+ unsigned long *config);

/*
* You will only be interested in these if you're using PINCONF
* so don't supply any stubs for these.
*/
-int pin_config_get_for_pin(struct pinctrl_dev *pctldev, unsigned pin,
- unsigned long *config);
int pin_config_group_get(const char *dev_name, const char *pin_group,
unsigned long *config);

@@ -74,6 +74,12 @@ static inline int pinconf_set_config(struct pinctrl_dev *pctldev, unsigned pin,
return -ENOTSUPP;
}

+static inline int pin_config_get_for_pin(struct pinctrl_dev *pctldev,
+ unsigned pin, unsigned long *config)
+{
+ return -ENOTSUPP;
+}
+
#endif

#if defined(CONFIG_PINCONF) && defined(CONFIG_DEBUG_FS)
--
2.34.1

2023-10-10 11:55:09

by Linus Walleij

Subject: Re: [RFC v2 2/5] pinctrl: always export pin_config_get_for_pin()

On Thu, Oct 5, 2023 at 4:59 AM AKASHI Takahiro
<[email protected]> wrote:


> This function will be used to implement a new pinctrl_gpio_get_config()
> outside pinconf.c in a succeeding commit.
> So make it always visible to avoid a kernel test bot error.
>
> Signed-off-by: AKASHI Takahiro <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij