2023-10-06 14:19:46

by Jerome Brunet

Subject: [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion

While making the v2, blue and green LED pwms got inverted
This change fixes the problem

Fixes: 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
Signed-off-by: Jerome Brunet <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
index ed826f673349..35e8f5bae990 100644
--- a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
@@ -70,7 +70,7 @@ led {
function = LED_FUNCTION_ACTIVITY;
linux,default-trigger = "heartbeat";
max-brightness = <255>;
- pwms = <&pwm_cd 1 1250 0>;
+ pwms = <&pwm_ab 1 1250 0>;
active-low;
};
};
@@ -83,7 +83,7 @@ led {
function = LED_FUNCTION_STATUS;
linux,default-trigger = "default-on";
max-brightness = <255>;
- pwms = <&pwm_ab 1 1250 0>;
+ pwms = <&pwm_cd 1 1250 0>;
active-low;
};
};
--
2.40.1

2023-10-06 14:46:30

by Neil Armstrong

Subject: Re: [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion

On 06/10/2023 16:19, Jerome Brunet wrote:
> While making the v2, blue and green LED pwms got inverted
> This change fixes the problem
>
> Fixes: 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> index ed826f673349..35e8f5bae990 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> @@ -70,7 +70,7 @@ led {
> function = LED_FUNCTION_ACTIVITY;
> linux,default-trigger = "heartbeat";
> max-brightness = <255>;
> - pwms = <&pwm_cd 1 1250 0>;
> + pwms = <&pwm_ab 1 1250 0>;
> active-low;
> };
> };
> @@ -83,7 +83,7 @@ led {
> function = LED_FUNCTION_STATUS;
> linux,default-trigger = "default-on";
> max-brightness = <255>;
> - pwms = <&pwm_ab 1 1250 0>;
> + pwms = <&pwm_cd 1 1250 0>;
> active-low;
> };
> };

Squashed into 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")

Thanks,
Neil