2023-10-07 07:53:15

by zhaotianrui

Subject: [PATCH linux-next] LoongArch: mm: Export symbol for invalid_pud_table.

Export symbol for invalid_pud_table, so it can be used
by the files in other directories.

And this can resolve the problem caused in:
https://lore.kernel.org/lkml/[email protected]/
ERROR: modpost: "invalid_pud_table" [arch/loongarch/kvm/kvm.ko] undefined!

Signed-off-by: Tianrui Zhao <[email protected]>
---
arch/loongarch/mm/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c
index f3fe8c06ba4d..ddf1330c924c 100644
--- a/arch/loongarch/mm/init.c
+++ b/arch/loongarch/mm/init.c
@@ -240,6 +240,7 @@ pgd_t swapper_pg_dir[_PTRS_PER_PGD] __section(".bss..swapper_pg_dir");
pgd_t invalid_pg_dir[_PTRS_PER_PGD] __page_aligned_bss;
#ifndef __PAGETABLE_PUD_FOLDED
pud_t invalid_pud_table[PTRS_PER_PUD] __page_aligned_bss;
+EXPORT_SYMBOL(invalid_pud_table);
#endif
#ifndef __PAGETABLE_PMD_FOLDED
pmd_t invalid_pmd_table[PTRS_PER_PMD] __page_aligned_bss;
--
2.39.1

2023-10-07 09:49:24

by Huacai Chen

Subject: Re: [PATCH linux-next] LoongArch: mm: Export symbol for invalid_pud_table.

Queued for loongarch-next (though I prepared a similar patch), thanks.

Huacai

On Sat, Oct 7, 2023 at 3:53 PM Tianrui Zhao <[email protected]> wrote:
>
> Export symbol for invalid_pud_table, so it can be used
> by the files in other directories.
>
> And this can resolve the problem caused in:
> https://lore.kernel.org/lkml/[email protected]/
> ERROR: modpost: "invalid_pud_table" [arch/loongarch/kvm/kvm.ko] undefined!
>
> Signed-off-by: Tianrui Zhao <[email protected]>
> ---
> arch/loongarch/mm/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c
> index f3fe8c06ba4d..ddf1330c924c 100644
> --- a/arch/loongarch/mm/init.c
> +++ b/arch/loongarch/mm/init.c
> @@ -240,6 +240,7 @@ pgd_t swapper_pg_dir[_PTRS_PER_PGD] __section(".bss..swapper_pg_dir");
> pgd_t invalid_pg_dir[_PTRS_PER_PGD] __page_aligned_bss;
> #ifndef __PAGETABLE_PUD_FOLDED
> pud_t invalid_pud_table[PTRS_PER_PUD] __page_aligned_bss;
> +EXPORT_SYMBOL(invalid_pud_table);
> #endif
> #ifndef __PAGETABLE_PMD_FOLDED
> pmd_t invalid_pmd_table[PTRS_PER_PMD] __page_aligned_bss;
> --
> 2.39.1
>

2023-10-07 16:15:21

by Randy Dunlap

Subject: Re: [PATCH linux-next] LoongArch: mm: Export symbol for invalid_pud_table.

On 10/7/23 00:53, Tianrui Zhao wrote:
> Export symbol for invalid_pud_table, so it can be used
> by the files in other directories.
>
> And this can resolve the problem caused in:
> https://lore.kernel.org/lkml/[email protected]/
> ERROR: modpost: "invalid_pud_table" [arch/loongarch/kvm/kvm.ko] undefined!
>
> Signed-off-by: Tianrui Zhao <[email protected]>

Reported-by: Randy Dunlap <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> arch/loongarch/mm/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c
> index f3fe8c06ba4d..ddf1330c924c 100644
> --- a/arch/loongarch/mm/init.c
> +++ b/arch/loongarch/mm/init.c
> @@ -240,6 +240,7 @@ pgd_t swapper_pg_dir[_PTRS_PER_PGD] __section(".bss..swapper_pg_dir");
> pgd_t invalid_pg_dir[_PTRS_PER_PGD] __page_aligned_bss;
> #ifndef __PAGETABLE_PUD_FOLDED
> pud_t invalid_pud_table[PTRS_PER_PUD] __page_aligned_bss;
> +EXPORT_SYMBOL(invalid_pud_table);
> #endif
> #ifndef __PAGETABLE_PMD_FOLDED
> pmd_t invalid_pmd_table[PTRS_PER_PMD] __page_aligned_bss;

--
~Randy