2023-09-23 18:37:35

by Atul Kumar Pant

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> Fixes typo in a function name.
>
> Signed-off-by: Atul Kumar Pant <[email protected]>
> ---
> samples/kprobes/kretprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> index cbf16542d84e..ed79fd3d48fb 100644
> --- a/samples/kprobes/kretprobe_example.c
> +++ b/samples/kprobes/kretprobe_example.c
> @@ -35,7 +35,7 @@ struct my_data {
> ktime_t entry_stamp;
> };
>
> -/* Here we use the entry_hanlder to timestamp function entry */
> +/* Here we use the entry_handler to timestamp function entry */
> static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> {
> struct my_data *data;
> --
> 2.25.1
>

Hi all, can someone provide comments on this change.

2023-10-07 15:39:28

by Atul Kumar Pant

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > Fixes typo in a function name.
> >
> > Signed-off-by: Atul Kumar Pant <[email protected]>
> > ---
> > samples/kprobes/kretprobe_example.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > index cbf16542d84e..ed79fd3d48fb 100644
> > --- a/samples/kprobes/kretprobe_example.c
> > +++ b/samples/kprobes/kretprobe_example.c
> > @@ -35,7 +35,7 @@ struct my_data {
> > ktime_t entry_stamp;
> > };
> >
> > -/* Here we use the entry_hanlder to timestamp function entry */
> > +/* Here we use the entry_handler to timestamp function entry */
> > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > {
> > struct my_data *data;
> > --
> > 2.25.1
> >
>
> Hi all, can someone provide comments on this change.

Hi all, can someone please review this change. It has been not
reviewed for quite some time.

2023-10-09 13:50:02

by Steven Rostedt

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Sat, 7 Oct 2023 21:09:00 +0530
Atul Kumar Pant <[email protected]> wrote:

> On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > Fixes typo in a function name.
> > >
> > > Signed-off-by: Atul Kumar Pant <[email protected]>
> > > ---
> > > samples/kprobes/kretprobe_example.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > index cbf16542d84e..ed79fd3d48fb 100644
> > > --- a/samples/kprobes/kretprobe_example.c
> > > +++ b/samples/kprobes/kretprobe_example.c
> > > @@ -35,7 +35,7 @@ struct my_data {
> > > ktime_t entry_stamp;
> > > };
> > >
> > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > +/* Here we use the entry_handler to timestamp function entry */
> > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > {
> > > struct my_data *data;
> > > --
> > > 2.25.1
> > >
> >
> > Hi all, can someone provide comments on this change.
>
> Hi all, can someone please review this change. It has been not
> reviewed for quite some time.

That's because trivial typos in comments are considered very low priority,
and are usually only added (if they are ever added) if the maintainer has
extra time, which may not be for a while.

-- Steve

2023-10-09 15:04:18

by Masami Hiramatsu

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Mon, 9 Oct 2023 09:51:03 -0400
Steven Rostedt <[email protected]> wrote:

> On Sat, 7 Oct 2023 21:09:00 +0530
> Atul Kumar Pant <[email protected]> wrote:
>
> > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > Fixes typo in a function name.
> > > >
> > > > Signed-off-by: Atul Kumar Pant <[email protected]>
> > > > ---
> > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > --- a/samples/kprobes/kretprobe_example.c
> > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > ktime_t entry_stamp;
> > > > };
> > > >
> > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > {
> > > > struct my_data *data;
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Hi all, can someone provide comments on this change.
> >
> > Hi all, can someone please review this change. It has been not
> > reviewed for quite some time.
>
> That's because trivial typos in comments are considered very low priority,
> and are usually only added (if they are ever added) if the maintainer has
> extra time, which may not be for a while.

Anyway, let me pick this. I found this in my inbox now. :)

Thank you,

>
> -- Steve


--
Masami Hiramatsu (Google) <[email protected]>

2023-10-11 18:03:22

by Atul Kumar Pant

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Mon, Oct 09, 2023 at 09:51:03AM -0400, Steven Rostedt wrote:
> On Sat, 7 Oct 2023 21:09:00 +0530
> Atul Kumar Pant <[email protected]> wrote:
>
> > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > Fixes typo in a function name.
> > > >
> > > > Signed-off-by: Atul Kumar Pant <[email protected]>
> > > > ---
> > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > --- a/samples/kprobes/kretprobe_example.c
> > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > ktime_t entry_stamp;
> > > > };
> > > >
> > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > {
> > > > struct my_data *data;
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Hi all, can someone provide comments on this change.
> >
> > Hi all, can someone please review this change. It has been not
> > reviewed for quite some time.
>
> That's because trivial typos in comments are considered very low priority,
> and are usually only added (if they are ever added) if the maintainer has
> extra time, which may not be for a while.
>
> -- Steve

Thank you Steve for the response. I wasn't aware of this.

2023-10-11 18:04:23

by Atul Kumar Pant

Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Tue, Oct 10, 2023 at 12:03:56AM +0900, Masami Hiramatsu wrote:
> On Mon, 9 Oct 2023 09:51:03 -0400
> Steven Rostedt <[email protected]> wrote:
>
> > On Sat, 7 Oct 2023 21:09:00 +0530
> > Atul Kumar Pant <[email protected]> wrote:
> >
> > > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > > Fixes typo in a function name.
> > > > >
> > > > > Signed-off-by: Atul Kumar Pant <[email protected]>
> > > > > ---
> > > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > > --- a/samples/kprobes/kretprobe_example.c
> > > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > > ktime_t entry_stamp;
> > > > > };
> > > > >
> > > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > > {
> > > > > struct my_data *data;
> > > > > --
> > > > > 2.25.1
> > > > >
> > > >
> > > > Hi all, can someone provide comments on this change.
> > >
> > > Hi all, can someone please review this change. It has been not
> > > reviewed for quite some time.
> >
> > That's because trivial typos in comments are considered very low priority,
> > and are usually only added (if they are ever added) if the maintainer has
> > extra time, which may not be for a while.
>
> Anyway, let me pick this. I found this in my inbox now. :)

Thank you. Sorry for the redundant emails for reviewing the change :)
>
> Thank you,
>
> >
> > -- Steve
>
>
> --
> Masami Hiramatsu (Google) <[email protected]>