2023-09-27 06:22:43

by chenguohua

Subject: [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h

Fix the following errors reported by checkpatch:

ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: GuoHua Cheng <[email protected]>
---
include/linux/netfilter/nf_conntrack_h323_asn1.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/netfilter/nf_conntrack_h323_asn1.h b/include/linux/netfilter/nf_conntrack_h323_asn1.h
index bd6797f823b2..514da3e8c8a8 100644
--- a/include/linux/netfilter/nf_conntrack_h323_asn1.h
+++ b/include/linux/netfilter/nf_conntrack_h323_asn1.h
@@ -88,8 +88,8 @@ typedef struct {
* Decode Functions
****************************************************************************/

-int DecodeRasMessage(unsigned char *buf, size_t sz, RasMessage * ras);
-int DecodeQ931(unsigned char *buf, size_t sz, Q931 * q931);
+int DecodeRasMessage(unsigned char *buf, size_t sz, RasMessage *ras);
+int DecodeQ931(unsigned char *buf, size_t sz, Q931 *q931);
int DecodeMultimediaSystemControlMessage(unsigned char *buf, size_t sz,
MultimediaSystemControlMessage *
mscm);
--
2.17.1

2023-10-08 12:31:48

by Florian Westphal

Subject: Re: [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h

[email protected] <[email protected]> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo * bar" should be "foo *bar"

Running "checkpatch -f" for all nf related files results
in a myriad of "warnings". I don't think there is a good
reason to "fix" them.

checkpatch is good for new patch submissions, but I
do not think its worth it to adjust all the existing files.

Sorry.