2023-10-09 08:25:17

by Vaishnav Achath

Subject: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller

From: Nishanth Menon <[email protected]>

Use ti,j721e-system-controller to be explicit about the syscon node we
are using.

Signed-off-by: Nishanth Menon <[email protected]>
Signed-off-by: Vaishnav Achath <[email protected]>
---

No changes since V1.

arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index 6ffaf85fa63f..2ee6215e38a6 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -165,7 +165,7 @@
};

mcu_conf: syscon@40f00000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
reg = <0x00 0x40f00000 0x00 0x20000>;
#address-cells = <1>;
#size-cells = <1>;
--
2.17.1

2023-10-19 19:14:08

by reidt

Subject: Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller

On 13:54-20231009, Vaishnav Achath wrote:
> From: Nishanth Menon <[email protected]>
>
> Use ti,j721e-system-controller to be explicit about the syscon node we
> are using.
>
> Signed-off-by: Nishanth Menon <[email protected]>
> Signed-off-by: Vaishnav Achath <[email protected]>
> ---
>
> No changes since V1.
>
> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 6ffaf85fa63f..2ee6215e38a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -165,7 +165,7 @@
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> reg = <0x00 0x40f00000 0x00 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.17.1
>
>

Reviewed-by: Reid tonking <[email protected]>

2023-10-19 21:07:08

by Andrew Davis

Subject: Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller

On 10/9/23 3:24 AM, Vaishnav Achath wrote:
> From: Nishanth Menon <[email protected]>
>
> Use ti,j721e-system-controller to be explicit about the syscon node we
> are using.
>
> Signed-off-by: Nishanth Menon <[email protected]>
> Signed-off-by: Vaishnav Achath <[email protected]>
> ---
>
> No changes since V1.
>
> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 6ffaf85fa63f..2ee6215e38a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -165,7 +165,7 @@
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";

There is already a "ti,j721e-system-controller" in the main domain dtsi. And this
is not one of those. You are hiding a valid DT warning by adding an incorrect
compatible string that just so happens to not throw the warning.

This should be a "simple-bus" node.

Andrew

> reg = <0x00 0x40f00000 0x00 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;