2023-10-09 09:24:51

by Uwe Kleine-König

Subject: [PATCH 03/20] pinctrl: ti: ti-iodelay: Drop if block with always false condition

ti_iodelay_remove() is only called after ti_iodelay_probe() completed
successfully. In this case platform_set_drvdata() was called with a
non-NULL argument and so platform_get_drvdata() won't return NULL.

Simplify by removing the if block with the always false condition.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index c1477f657839..f3a273562095 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -903,9 +903,6 @@ static int ti_iodelay_remove(struct platform_device *pdev)
{
struct ti_iodelay_device *iod = platform_get_drvdata(pdev);

- if (!iod)
- return 0;
-
if (iod->pctl)
pinctrl_unregister(iod->pctl);

--
2.40.1

2023-10-10 13:37:27

by Linus Walleij

Subject: Re: [PATCH 03/20] pinctrl: ti: ti-iodelay: Drop if block with always false condition

On Mon, Oct 9, 2023 at 11:22 AM Uwe Kleine-König
<[email protected]> wrote:


> ti_iodelay_remove() is only called after ti_iodelay_probe() completed
> successfully. In this case platform_set_drvdata() was called with a
> non-NULL argument and so platform_get_drvdata() won't return NULL.
>
> Simplify by removing the if block with the always false condition.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Patch applied.

Yours,
Linus Walleij