2023-10-01 20:45:41

by Josua Mayer

[permalink] [raw]
Subject: [v6 0/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

Add support for the SolidRun LX2162A System on Module (SoM), and the
Clearfog evaluation board.

This patch-set introduces:
- dt node for lx2160a serdes block #2
- dtsi for lx2162a system on module
- dts for lx2162 clearfog

Firstly Please note that checkpatch was complaining about the EEPROMS:
- DT compatible string "st,24c02" appears un-documented
- DT compatible string "st,24c2048" appears un-documented
- DT compatible string "atmel,24c2048" appears un-documented
However to my eyes these *are* already documented in at24.yaml,
and are also used in existing device-tree.

checkpatch is also complaining about various parts of lx2160a.dtsi,
as well as the use of "sfp" property in dpmac nodes - which are common
across layerscape based dts.

Secondly the MAINTAINERS file has not been modified.
Is it required I add myself or *someone* for these new dts?

Changes since v5:
- moved status property to be last in esdhc1 node
- added empty lines between led nodes
- moved i2c2 node according to alphabetical order
- lx2160a.dtsi: disable serdes_2 node by default

Changes since v4:
- extended commit hash reference to 12 characters in description

Changes since v3:
- moved status properties to be last
- changed ethernet-phy on som from /delete-node/ to disabled,

Changes since v2:
- fixed property order in som dts such that compatible is first property
- added reviewed-by tags to bindings patches

Changes since v1:
- fixed DT binding changes to not break existing boards
- explained new board / som DT binding in commit message
- added missing DT binding for dpaa2 mac "phys" property
- reordered "compatible" and "reg" properties: first "compatible", then "reg"
- replaced chip-specific DT node names with generic ones

Josua Mayer (4):
arm64: dts: lx2160a: describe the SerDes block #2
dt-bindings: net: dpaa2 mac: add phys property
dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

.../devicetree/bindings/arm/fsl.yaml | 9 +-
.../bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 +
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 7 +
.../dts/freescale/fsl-lx2162a-clearfog.dts | 376 ++++++++++++++++++
.../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
6 files changed, 469 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi

Cc: Shawn Guo <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Li Yang <[email protected]>
--
2.35.3


2023-10-02 02:22:16

by Josua Mayer

[permalink] [raw]
Subject: [v6 3/4] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

SolidRun now have 2 product lines around NXP Layerscape SoC:
- LX2160A COM Express 7
- LX2162A System on Module

LX2162 is a smaller package and reduced feature set to LX2160A;
LX2162 SoM is also a smaller form factor and reduced feature set to CEX.

Since both product lines are physically incompatible,
the existing group "SolidRun LX2160A based Boards" has been renamed to
include "CEX" in its name, meaning products based on LX2160A COM Express
Module, following this pattern:
"solidrun,<board>", "solidrun,lx2160a-cex", "fsl,lx2160a"

Add DT compatible for both SolidRun LX2162A SoM, and LX2162 Clearfog
boards to a new group based on LX2162A SoM, following this pattern:
"solidrun,<board>", "solidrun,lx2162a-som", "fsl,lx2160a"

Signed-off-by: Josua Mayer <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
V1 -> V2: fixed to not break existing boards
V1 -> V2: explained new board / som DT binding in commit message

Documentation/devicetree/bindings/arm/fsl.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..ff9bf9956972 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1384,7 +1384,7 @@ properties:
- fsl,lx2162a-qds
- const: fsl,lx2160a

- - description: SolidRun LX2160A based Boards
+ - description: SolidRun LX2160A CEX-7 based Boards
items:
- enum:
- solidrun,clearfog-cx
@@ -1392,6 +1392,13 @@ properties:
- const: solidrun,lx2160a-cex7
- const: fsl,lx2160a

+ - description: SolidRun LX2162A SoM based Boards
+ items:
+ - enum:
+ - solidrun,lx2162a-clearfog
+ - const: solidrun,lx2162a-som
+ - const: fsl,lx2160a
+
- description: S32G2 based Boards
items:
- enum:
--
2.35.3

2023-10-10 01:48:35

by Shawn Guo

[permalink] [raw]
Subject: Re: [v6 0/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

On Sun, Oct 01, 2023 at 12:32:55PM +0200, Josua Mayer wrote:
> Josua Mayer (4):
> arm64: dts: lx2160a: describe the SerDes block #2
...
> dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
> arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

Applied all 3, thanks!