2023-10-09 02:50:50

by Meng, Li (Jassmine)

Subject: [PATCH V8 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement
of CPU_SUP_INTEL from the dependencies to allow compilation in kernels
without Intel CPU support.

Reviewed-by: Mario Limonciello <[email protected]>
Reviewed-by: Huang Rui <[email protected]>
Signed-off-by: Meng Li <[email protected]>
---
arch/x86/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 66bfabae8814..a2e163acf623 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1054,8 +1054,9 @@ config SCHED_MC

config SCHED_MC_PRIO
bool "CPU core priorities scheduler support"
- depends on SCHED_MC && CPU_SUP_INTEL
- select X86_INTEL_PSTATE
+ depends on SCHED_MC
+ select X86_INTEL_PSTATE if CPU_SUP_INTEL
+ select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI
select CPU_FREQ
default y
help
--
2.34.1

2023-10-09 06:19:52

by Wyes Karny

Subject: Re: [PATCH V8 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

On 09 Oct 10:49, Meng Li wrote:
> amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement
> of CPU_SUP_INTEL from the dependencies to allow compilation in kernels
> without Intel CPU support.
>
> Reviewed-by: Mario Limonciello <[email protected]>
> Reviewed-by: Huang Rui <[email protected]>
Reviewed-by: Wyes Karny <[email protected]>
> Signed-off-by: Meng Li <[email protected]>
> ---
> arch/x86/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 66bfabae8814..a2e163acf623 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1054,8 +1054,9 @@ config SCHED_MC
>
> config SCHED_MC_PRIO
> bool "CPU core priorities scheduler support"
> - depends on SCHED_MC && CPU_SUP_INTEL
> - select X86_INTEL_PSTATE
> + depends on SCHED_MC
> + select X86_INTEL_PSTATE if CPU_SUP_INTEL
> + select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI
> select CPU_FREQ
> default y
> help
> --
> 2.34.1
>

2023-10-10 10:31:09

by Peter Zijlstra

Subject: Re: [PATCH V8 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

On Mon, Oct 09, 2023 at 10:49:26AM +0800, Meng Li wrote:
> amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement
> of CPU_SUP_INTEL from the dependencies to allow compilation in kernels
> without Intel CPU support.
>
> Reviewed-by: Mario Limonciello <[email protected]>
> Reviewed-by: Huang Rui <[email protected]>
> Signed-off-by: Meng Li <[email protected]>
> ---
> arch/x86/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 66bfabae8814..a2e163acf623 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1054,8 +1054,9 @@ config SCHED_MC
>
> config SCHED_MC_PRIO
> bool "CPU core priorities scheduler support"
> - depends on SCHED_MC && CPU_SUP_INTEL
> - select X86_INTEL_PSTATE
> + depends on SCHED_MC
> + select X86_INTEL_PSTATE if CPU_SUP_INTEL
> + select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI
> select CPU_FREQ
> default y
> help

The pedantic side of me wants to point out that:

depends on SCHED_MC
depends on CPU_SUP_INTEL || CPU_SUP_AMD

would be more accurate, as we still have a pile of other SUPs.

Anyway, no real objection, distros will have them all set anyway.