2023-10-10 20:28:41

by kernel test robot

[permalink] [raw]
Subject: tools/perf/util/bpf_skel/vmlinux/vmlinux.h: warning: ignored by one of the .gitignore files

Hi Ian,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
commit: b7a2d774c9c5a9a3228c6169ecf32f05b96609cf perf build: Add ability to build with a generated vmlinux.h
date: 4 months ago
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231011/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231011/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> tools/perf/util/bpf_skel/vmlinux/vmlinux.h: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/run_tags_test.sh: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
tools/testing/selftests/kvm/.gitignore: warning: ignored by one of the .gitignore files
tools/testing/selftests/kvm/Makefile: warning: ignored by one of the .gitignore files
tools/testing/selftests/kvm/config: warning: ignored by one of the .gitignore files
tools/testing/selftests/kvm/settings: warning: ignored by one of the .gitignore files

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


2023-10-10 23:43:02

by Namhyung Kim

[permalink] [raw]
Subject: [PATCH] perf tools: Do not ignore the default vmlinux.h

The recent change made it possible to generate vmlinux.h from BTF and
to ignore the file. But we also have a minimal vmlinux.h that will be
used by default. It should not be ignored by GIT.

Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Namhyung Kim <[email protected]>
---
tools/perf/util/bpf_skel/vmlinux/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 tools/perf/util/bpf_skel/vmlinux/.gitignore

diff --git a/tools/perf/util/bpf_skel/vmlinux/.gitignore b/tools/perf/util/bpf_skel/vmlinux/.gitignore
new file mode 100644
index 000000000000..49502c04183a
--- /dev/null
+++ b/tools/perf/util/bpf_skel/vmlinux/.gitignore
@@ -0,0 +1 @@
+!vmlinux.h
--
2.42.0.609.gbb76f46606-goog

2023-10-11 01:36:18

by Ian Rogers

[permalink] [raw]
Subject: Re: [PATCH] perf tools: Do not ignore the default vmlinux.h

On Tue, Oct 10, 2023 at 4:42 PM Namhyung Kim <[email protected]> wrote:
>
> The recent change made it possible to generate vmlinux.h from BTF and
> to ignore the file. But we also have a minimal vmlinux.h that will be
> used by default. It should not be ignored by GIT.
>
> Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Namhyung Kim <[email protected]>

Reviewed-by: Ian Rogers <[email protected]>

Thanks!
Ian

> ---
> tools/perf/util/bpf_skel/vmlinux/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/perf/util/bpf_skel/vmlinux/.gitignore
>
> diff --git a/tools/perf/util/bpf_skel/vmlinux/.gitignore b/tools/perf/util/bpf_skel/vmlinux/.gitignore
> new file mode 100644
> index 000000000000..49502c04183a
> --- /dev/null
> +++ b/tools/perf/util/bpf_skel/vmlinux/.gitignore
> @@ -0,0 +1 @@
> +!vmlinux.h
> --
> 2.42.0.609.gbb76f46606-goog
>

2023-10-20 05:40:58

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH] perf tools: Do not ignore the default vmlinux.h

On Tue, Oct 10, 2023 at 6:36 PM Ian Rogers <[email protected]> wrote:
>
> On Tue, Oct 10, 2023 at 4:42 PM Namhyung Kim <[email protected]> wrote:
> >
> > The recent change made it possible to generate vmlinux.h from BTF and
> > to ignore the file. But we also have a minimal vmlinux.h that will be
> > used by default. It should not be ignored by GIT.
> >
> > Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > Signed-off-by: Namhyung Kim <[email protected]>
>
> Reviewed-by: Ian Rogers <[email protected]>

Applied to perf-tools-next, thanks!