2023-10-12 03:44:39

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH v2] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ

On 11-10-23, 09:46, Florian Fainelli wrote:
> The brcmstb-avs-cpufreq driver is considered a legacy driver and since
> 2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of
> fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the
> SCMI firmware takes over, this can result in various problems, including
> external synchronous aborts.
>
> Express those constraints such that the driver is not enabled by default
> when SCMI CPU frequency scaling is in use.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> Changes in v2:
>
> - address Viresh's feedback and reduce the depdendency to
> !ARM_SCMI_CPUFREQ
>
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 123b4bbfcfee..207618043ee0 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ
>
> config ARM_BRCMSTB_AVS_CPUFREQ
> tristate "Broadcom STB AVS CPUfreq driver"
> - depends on ARCH_BRCMSTB || COMPILE_TEST
> + depends on (ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ) || COMPILE_TEST
> default y
> help
> Some Broadcom STB SoCs use a co-processor running proprietary firmware

Applied. Thanks.

--
viresh