2023-10-12 16:19:09

by David Lechner

[permalink] [raw]
Subject: [PATCH 0/2] iio: resolver: ad2s1210: small cleanups

This series contains a few small cleanups for the ad2s1210 resolver
driver following up from the previous series[1].

[1] https://lore.kernel.org/linux-iio/20231012092522.27ef48dd@jic23-huawei

---
David Lechner (2):
iio: resolver: ad2s1210: remove DRV_NAME macro
iio: resolver: ad2s1210: remove of_match_ptr()

drivers/iio/resolver/ad2s1210.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
---
base-commit: 291e45eeeb901b1d22b74ac5ea48cab3c407c705
change-id: 20231012-ad2s1210-mainline-d80cc13acdce

Best regards,
--
David Lechner <[email protected]>


2023-10-12 16:19:16

by David Lechner

[permalink] [raw]
Subject: [PATCH 2/2] iio: resolver: ad2s1210: remove of_match_ptr()

To be consistent with the rest of iio, remove of_match_ptr(). It does
not do anything useful here.

Suggested-by: Jonathan Cameron <[email protected]>
Signed-off-by: David Lechner <[email protected]>
---
drivers/iio/resolver/ad2s1210.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c
index 00562bc542bb..1bd1b950e7cc 100644
--- a/drivers/iio/resolver/ad2s1210.c
+++ b/drivers/iio/resolver/ad2s1210.c
@@ -54,7 +54,6 @@
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/mutex.h>
-#include <linux/of.h>
#include <linux/regmap.h>
#include <linux/slab.h>
#include <linux/spi/spi.h>
@@ -1508,7 +1507,7 @@ MODULE_DEVICE_TABLE(spi, ad2s1210_id);
static struct spi_driver ad2s1210_driver = {
.driver = {
.name = "ad2s1210",
- .of_match_table = of_match_ptr(ad2s1210_of_match),
+ .of_match_table = ad2s1210_of_match,
},
.probe = ad2s1210_probe,
.id_table = ad2s1210_id,

--
2.42.0

2023-10-14 12:56:07

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 0/2] iio: resolver: ad2s1210: small cleanups

On Thu, 12 Oct 2023 11:18:11 -0500
David Lechner <[email protected]> wrote:

> This series contains a few small cleanups for the ad2s1210 resolver
> driver following up from the previous series[1].
>
> [1] https://lore.kernel.org/linux-iio/20231012092522.27ef48dd@jic23-huawei
>
> ---
> David Lechner (2):
> iio: resolver: ad2s1210: remove DRV_NAME macro
> iio: resolver: ad2s1210: remove of_match_ptr()
>
> drivers/iio/resolver/ad2s1210.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
> ---
> base-commit: 291e45eeeb901b1d22b74ac5ea48cab3c407c705
> change-id: 20231012-ad2s1210-mainline-d80cc13acdce
>
> Best regards,

Applied. Thanks,

J