2023-10-13 06:01:54

by Soumya Negi

Subject: [PATCH] tty: gdm724x: Match alignment with open parenthesis

Fix CHECK: Alignment should match open parenthesis
Issue found by checkpatch.pl

Signed-off-by: Soumya Negi <[email protected]>
---
drivers/staging/gdm724x/gdm_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 32b2e817ff04..4e5cac76db58 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
int ret;

for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
- TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (IS_ERR(tty_driver))
return PTR_ERR(tty_driver);

--
2.42.0

2023-10-13 06:42:56

by Julia Lawall

Subject: Re: [PATCH] tty: gdm724x: Match alignment with open parenthesis

This and the next patch need to be in a series because they touch the same
file.

julia

On Thu, 12 Oct 2023, Soumya Negi wrote:

> Fix CHECK: Alignment should match open parenthesis
> Issue found by checkpatch.pl
>
> Signed-off-by: Soumya Negi <[email protected]>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 32b2e817ff04..4e5cac76db58 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
> if (IS_ERR(tty_driver))
> return PTR_ERR(tty_driver);
>
> --
> 2.42.0
>
>
>

2023-10-13 07:49:00

by Soumya Negi

Subject: Re: [PATCH] tty: gdm724x: Match alignment with open parenthesis

On Fri, Oct 13, 2023 at 08:42:42AM +0200, Julia Lawall wrote:
> This and the next patch need to be in a series because they touch the same
> file.
>
> julia

Noted. Sending them as set.

> On Thu, 12 Oct 2023, Soumya Negi wrote:
>
> > Fix CHECK: Alignment should match open parenthesis
> > Issue found by checkpatch.pl
> >
> > Signed-off-by: Soumya Negi <[email protected]>
> > ---
> > drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 32b2e817ff04..4e5cac76db58 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
> > int ret;
> >
> > for (i = 0; i < TTY_MAX_COUNT; i++) {
> > - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > + TTY_DRIVER_DYNAMIC_DEV);
> > if (IS_ERR(tty_driver))
> > return PTR_ERR(tty_driver);
> >
> > --
> > 2.42.0
> >
> >
> >