2023-10-13 06:02:31

by Soumya Negi

Subject: [PATCH] tty: gdm724x: Add blank line after declaration

Fix WARNING: Missing a blank line after declarations
Issue found by checkpatch.pl

Signed-off-by: Soumya Negi <[email protected]>
---
drivers/staging/gdm724x/gdm_tty.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 4e5cac76db58..0c61eaff6122 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)

while (remain) {
size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
+
gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
(void *)(buf + sent_len),
sending_len,
--
2.42.0

2023-10-13 07:50:59

by Soumya Negi

Subject: Re: [PATCH] tty: gdm724x: Add blank line after declaration

On Thu, Oct 12, 2023 at 11:01:57PM -0700, Soumya Negi wrote:
> Fix WARNING: Missing a blank line after declarations
> Issue found by checkpatch.pl
>
> Signed-off-by: Soumya Negi <[email protected]>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 4e5cac76db58..0c61eaff6122 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
>
> while (remain) {
> size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> +
> gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
> (void *)(buf + sent_len),
> sending_len,
> --

Please ignore this patch. It must be sent as part of a patch set as
suggested by Julia. I'll be doing that shortly.

> 2.42.0
>