2023-10-16 04:01:07

by David Ahern

Subject: Re: [PATCH v2 iproute2-next 2/2] rdma: Add support to dump SRQ resource in raw format

On 10/10/23 1:55 AM, Junxian Huang wrote:
> @@ -162,6 +162,20 @@ out:
> return -EINVAL;
> }
>
> +static int res_srq_line_raw(struct rd *rd, const char *name, int idx,
> + struct nlattr **nla_line)
> +{
> + if (!nla_line[RDMA_NLDEV_ATTR_RES_RAW])
> + return MNL_CB_ERROR;
> +
> + open_json_object(NULL);

open_json_object with no corresponding close.

> + print_dev(rd, idx, name);
> + print_raw_data(rd, nla_line);
> + newline(rd);
> +
> + return MNL_CB_OK;
> +}
> +
> static int res_srq_line(struct rd *rd, const char *name, int idx,
> struct nlattr **nla_line)
> {

2023-10-16 06:32:22

by Leon Romanovsky

Subject: Re: [PATCH v2 iproute2-next 2/2] rdma: Add support to dump SRQ resource in raw format

On Sun, Oct 15, 2023 at 09:54:14PM -0600, David Ahern wrote:
> On 10/10/23 1:55 AM, Junxian Huang wrote:
> > @@ -162,6 +162,20 @@ out:
> > return -EINVAL;
> > }
> >
> > +static int res_srq_line_raw(struct rd *rd, const char *name, int idx,
> > + struct nlattr **nla_line)
> > +{
> > + if (!nla_line[RDMA_NLDEV_ATTR_RES_RAW])
> > + return MNL_CB_ERROR;
> > +
> > + open_json_object(NULL);
>
> open_json_object with no corresponding close.
>
> > + print_dev(rd, idx, name);
> > + print_raw_data(rd, nla_line);
> > + newline(rd);

It is here ^^^^.

773 void newline(struct rd *rd)
774 {
775 close_json_object();
776 print_color_string(PRINT_FP, COLOR_NONE, NULL, "\n", NULL);
777 }
778


> > +
> > + return MNL_CB_OK;
> > +}
> > +
> > static int res_srq_line(struct rd *rd, const char *name, int idx,
> > struct nlattr **nla_line)
> > {
>
>