2023-10-16 18:30:03

by Edson Juliano Drosdeck

[permalink] [raw]
Subject: [PATCH] platform/x86: acer-wmi: Remove void function return

Adhere to Linux kernel coding style.

Reported by checkpatch:

WARNING: void function return statements are not generally useful

Signed-off-by: Edson Juliano Drosdeck <[email protected]>
---
drivers/platform/x86/acer-wmi.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 377a0becd1a1..0e472aa9bf41 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1922,7 +1922,6 @@ static void acer_rfkill_exit(void)
rfkill_unregister(threeg_rfkill);
rfkill_destroy(threeg_rfkill);
}
- return;
}

static void acer_wmi_notify(u32 value, void *context)
@@ -2517,7 +2516,6 @@ static void __exit acer_wmi_exit(void)
platform_driver_unregister(&acer_platform_driver);

pr_info("Acer Laptop WMI Extras unloaded\n");
- return;
}

module_init(acer_wmi_init);
--
2.39.2


2023-10-17 09:32:12

by Ilpo Järvinen

[permalink] [raw]
Subject: Re: [PATCH] platform/x86: acer-wmi: Remove void function return

On Mon, 16 Oct 2023 15:29:10 -0300, Edson Juliano Drosdeck wrote:

> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> WARNING: void function return statements are not generally useful
>
>
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

Once I've run some tests on the review-ilpo branch the patches
there will be added to the platform-drivers-x86/for-next branch
and eventually will be included in the pdx86 pull-request to
Linus for the next merge-window.

The list of commits applied:
[1/1] platform/x86: acer-wmi: Remove void function return
commit: d3b614d993781afca1832bd2cbc39da64306d0ba

--
i.