2023-10-17 18:16:25

by Nicolin Chen

Subject: [PATCH] iommufd: Correct IOMMU_HWPT_ALLOC_NEST_PARENT description

The IOMMU_HWPT_ALLOC_NEST_PARENT flag is used to allocate a HWPT. Though
a HWPT holds a domain in the core structure, it is still quite confusing
to describe it using "domain" in the uAPI kdoc. Correct it to "HWPT".

Fixes: 4ff542163397 ("iommufd: Support allocating nested parent domain")
Signed-off-by: Nicolin Chen <[email protected]>
---
include/uapi/linux/iommufd.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
index 4a7c5c8fdbb4..be7a95042677 100644
--- a/include/uapi/linux/iommufd.h
+++ b/include/uapi/linux/iommufd.h
@@ -349,9 +349,8 @@ struct iommu_vfio_ioas {

/**
* enum iommufd_hwpt_alloc_flags - Flags for HWPT allocation
- * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a domain which can serve
- * as the parent domain in the nesting
- * configuration.
+ * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a HWPT that can serve as
+ * the parent HWPT in a nesting configuration.
*/
enum iommufd_hwpt_alloc_flags {
IOMMU_HWPT_ALLOC_NEST_PARENT = 1 << 0,
--
2.42.0

2023-10-21 16:17:37

by Jason Gunthorpe

Subject: Re: [PATCH] iommufd: Correct IOMMU_HWPT_ALLOC_NEST_PARENT description

On Tue, Oct 17, 2023 at 11:15:52AM -0700, Nicolin Chen wrote:
> The IOMMU_HWPT_ALLOC_NEST_PARENT flag is used to allocate a HWPT. Though
> a HWPT holds a domain in the core structure, it is still quite confusing
> to describe it using "domain" in the uAPI kdoc. Correct it to "HWPT".
>
> Fixes: 4ff542163397 ("iommufd: Support allocating nested parent domain")
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
> include/uapi/linux/iommufd.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Applied to for next

Thanks,
Jason