2023-10-10 21:19:59

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs

DT overlays in tree need to be applied to a base DTB to validate they
apply, to run schema checks on them, and to catch any errors at compile
time.

Signed-off-by: Rob Herring <[email protected]>
---
v2:
- Only test applying overlays when building all DTBs
---
arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
index d2b590004fed..d6ee4a247100 100644
--- a/arch/arm/boot/dts/ti/omap/Makefile
+++ b/arch/arm/boot/dts/ti/omap/Makefile
@@ -129,6 +129,16 @@ dtb-$(CONFIG_SOC_AM43XX) += \
am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo

+am571x-idk-overlays-dtbs := am571x-idk.dtb \
+ am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
+am572x-idk-overlays-dtbs := am572x-idk.dtb \
+ am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
+
+# Build time test only, enabled by CONFIG_OF_ALL_DTBS
+dtb- += \
+ am571x-idk-overlays.dtb \
+ am572x-idk-overlays.dtb
+
dtb-$(CONFIG_SOC_DRA7XX) += \
am57xx-beagle-x15.dtb \
am57xx-beagle-x15-revb1.dtb \
--
2.42.0


2023-10-18 05:21:14

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs

* Rob Herring <[email protected]> [231011 00:19]:
> DT overlays in tree need to be applied to a base DTB to validate they
> apply, to run schema checks on them, and to catch any errors at compile
> time.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> v2:
> - Only test applying overlays when building all DTBs

Andrew, any comments or care to ack?

Regards,

Tony

> ---
> arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
> index d2b590004fed..d6ee4a247100 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -129,6 +129,16 @@ dtb-$(CONFIG_SOC_AM43XX) += \
> am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
> am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
>
> +am571x-idk-overlays-dtbs := am571x-idk.dtb \
> + am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
> +am572x-idk-overlays-dtbs := am572x-idk.dtb \
> + am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
> +
> +# Build time test only, enabled by CONFIG_OF_ALL_DTBS
> +dtb- += \
> + am571x-idk-overlays.dtb \
> + am572x-idk-overlays.dtb
> +
> dtb-$(CONFIG_SOC_DRA7XX) += \
> am57xx-beagle-x15.dtb \
> am57xx-beagle-x15-revb1.dtb \
> --
> 2.42.0
>

2023-10-18 14:06:16

by Andrew Davis

[permalink] [raw]
Subject: Re: [PATCH v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs

On 10/18/23 12:20 AM, Tony Lindgren wrote:
> * Rob Herring <[email protected]> [231011 00:19]:
>> DT overlays in tree need to be applied to a base DTB to validate they
>> apply, to run schema checks on them, and to catch any errors at compile
>> time.
>>
>> Signed-off-by: Rob Herring <[email protected]>
>> ---
>> v2:
>> - Only test applying overlays when building all DTBs
>
> Andrew, any comments or care to ack?

As before, this is a valid combination, but it is only one of
many more. For now this is a reasonable start though,

Acked-by: Andrew Davis <[email protected]>

>
> Regards,
>
> Tony
>
>> ---
>> arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
>> index d2b590004fed..d6ee4a247100 100644
>> --- a/arch/arm/boot/dts/ti/omap/Makefile
>> +++ b/arch/arm/boot/dts/ti/omap/Makefile
>> @@ -129,6 +129,16 @@ dtb-$(CONFIG_SOC_AM43XX) += \
>> am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
>> am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
>>
>> +am571x-idk-overlays-dtbs := am571x-idk.dtb \
>> + am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
>> +am572x-idk-overlays-dtbs := am572x-idk.dtb \
>> + am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
>> +
>> +# Build time test only, enabled by CONFIG_OF_ALL_DTBS
>> +dtb- += \
>> + am571x-idk-overlays.dtb \
>> + am572x-idk-overlays.dtb
>> +
>> dtb-$(CONFIG_SOC_DRA7XX) += \
>> am57xx-beagle-x15.dtb \
>> am57xx-beagle-x15-revb1.dtb \
>> --
>> 2.42.0
>>

2023-11-28 09:53:41

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs

* Andrew Davis <[email protected]> [231018 14:05]:
> On 10/18/23 12:20 AM, Tony Lindgren wrote:
> > * Rob Herring <[email protected]> [231011 00:19]:
> > > DT overlays in tree need to be applied to a base DTB to validate they
> > > apply, to run schema checks on them, and to catch any errors at compile
> > > time.
> > >
> > > Signed-off-by: Rob Herring <[email protected]>
> > > ---
> > > v2:
> > > - Only test applying overlays when building all DTBs
> >
> > Andrew, any comments or care to ack?
>
> As before, this is a valid combination, but it is only one of
> many more. For now this is a reasonable start though,
>
> Acked-by: Andrew Davis <[email protected]>

OK thanks applying into omap-for-v6.8/dt.

Tony