2023-10-18 07:02:56

by zhangqing

Subject: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

MBIST_MCLK_PDM1 is not used,
Use PCLK_VO1GRF to replace it.

Signed-off-by: Elaine Zhang <[email protected]>
---
include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
index 5790b1391201..5816cd71a4e3 100644
--- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
+++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
@@ -36,7 +36,7 @@
#define PCLK_DSU 21
#define PCLK_S_DAPLITE 22
#define PCLK_M_DAPLITE 23
-#define MBIST_MCLK_PDM1 24
+#define PCLK_VO1GRF 24
#define MBIST_CLK_ACDCDIG 25
#define HCLK_I2S2_2CH 26
#define HCLK_I2S3_2CH 27
--
2.17.1

2023-10-18 07:14:37

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

On 18/10/2023 09:01, Elaine Zhang wrote:
> MBIST_MCLK_PDM1 is not used,
> Use PCLK_VO1GRF to replace it.
>
> Signed-off-by: Elaine Zhang <[email protected]>
> ---
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index 5790b1391201..5816cd71a4e3 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -36,7 +36,7 @@
> #define PCLK_DSU 21
> #define PCLK_S_DAPLITE 22
> #define PCLK_M_DAPLITE 23
> -#define MBIST_MCLK_PDM1 24
> +#define PCLK_VO1GRF 24

That's an ABI break without justification.

Best regards,
Krzysztof