2023-10-18 15:57:10

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next v5 2/2] net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT

On Tue, Oct 17, 2023 at 04:35:36PM -0700, Florian Fainelli wrote:
> This preserves the existing IFLA_DSA_MASTER which is part of the uAPI
> and creates an alias named IFLA_DSA_CONDUIT.
>
> Reviewed-by: Andrew Lunn <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

...

> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index fac351a93aed..30ef80aff033 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -1392,7 +1392,9 @@ enum {
>
> enum {
> IFLA_DSA_UNSPEC,
> - IFLA_DSA_MASTER,
> + IFLA_DSA_CONDUIT,
> + /* Deprecated, use IFLA_DSA_CONDUIT insted */

nit: instead

> + IFLA_DSA_MASTER = IFLA_DSA_CONDUIT,
> __IFLA_DSA_MAX,
> };
>

...