2023-10-18 21:08:32

by Chris Packham

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property

Add reset-gpios and reset-duration-us properties to the
marvell,mv64xxx-i2c binding. These can be used to describe hardware
where a common reset GPIO is connected to all downstream devices on and
I2C bus. This reset will be asserted then released before the downstream
devices on the bus are probed.

Signed-off-by: Chris Packham <[email protected]>
---

Notes:
Changes in v3:
- Rename reset-delay-us to reset-duration-us to better reflect its
purpose
- Add default: for reset-duration-us
- Add description: for reset-gpios
Changes in v2:
- Update commit message
- Add reset-delay-us property

.../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
index 461d1c9ee3f7..ecf5b279cfa4 100644
--- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
@@ -70,6 +70,16 @@ properties:
resets:
maxItems: 1

+ reset-gpios:
+ description:
+ GPIO pin providing a common reset for all downstream devices. This GPIO
+ will be asserted then released before the downstream devices are probed.
+ maxItems: 1
+
+ reset-duration-us:
+ description: Reset duration in us.
+ default: 1
+
dmas:
items:
- description: RX DMA Channel
--
2.42.0


2023-10-19 07:02:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property

On 18/10/2023 23:08, Chris Packham wrote:
> Add reset-gpios and reset-duration-us properties to the
> marvell,mv64xxx-i2c binding. These can be used to describe hardware
> where a common reset GPIO is connected to all downstream devices on and
> I2C bus. This reset will be asserted then released before the downstream
> devices on the bus are probed.
>
> Signed-off-by: Chris Packham <[email protected]>
> ---
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof