2023-10-19 02:56:34

by Jiapeng Chong

Subject: [PATCH] nvmet-fc: Remove unused function

The function are defined in the fc.c file, but not called
elsewhere, so delete the unused function.

drivers/nvme/target/fc.c:177:1: warning: unused function 'nvmet_fc_iodnum'.
drivers/nvme/target/fc.c:183:1: warning: unused function 'nvmet_fc_fodnum'.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6936
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/nvme/target/fc.c | 14 --------------
1 file changed, 14 deletions(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index bd59990b5250..433517bbd3ac 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc {
struct rcu_head rcu;
};

-
-static inline int
-nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
-{
- return (iodptr - iodptr->tgtport->iod);
-}
-
-static inline int
-nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
-{
- return (fodptr - fodptr->queue->fod);
-}
-
-
/*
* Association and Connection IDs:
*
--
2.20.1.7.g153144c

2023-10-19 05:03:03

by Christoph Hellwig

Subject: Re: [PATCH] nvmet-fc: Remove unused function

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>