2023-10-20 06:25:04

by Ciprian Regus

Subject: [net] net: ethernet: adi: adin1110: Fix uninitialized variable

From: Dell Jin <[email protected]>

The spi_transfer struct has to have all it's fields initialized to 0 in
this case, since not all of them are set before starting the transfer.
Otherwise, spi_sync_transfer() will sometimes return an error.

Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")
Signed-off-by: Dell Jin <[email protected]>
Signed-off-by: Ciprian Regus <[email protected]>
---
drivers/net/ethernet/adi/adin1110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c
index ca66b747b7c5..d7c274af6d4d 100644
--- a/drivers/net/ethernet/adi/adin1110.c
+++ b/drivers/net/ethernet/adi/adin1110.c
@@ -296,3 +296,3 @@ static int adin1110_read_fifo(struct adin1110_port_priv *port_priv)
u32 header_len = ADIN1110_RD_HEADER_LEN;
- struct spi_transfer t;
+ struct spi_transfer t = {0};
u32 frame_size_no_fcs;
--
2.39.2

2023-10-24 00:12:20

by Jakub Kicinski

Subject: Re: [net] net: ethernet: adi: adin1110: Fix uninitialized variable

On Fri, 20 Oct 2023 09:20:53 +0300 Ciprian Regus wrote:
> The spi_transfer struct has to have all it's fields initialized to 0 in
> this case, since not all of them are set before starting the transfer.
> Otherwise, spi_sync_transfer() will sometimes return an error.
>
> Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")

Applied, thank you!